-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-7150: Add multiple extension support #2384
Merged
jonathanmos
merged 2 commits into
feature/sr_compose
from
jmoskovich/rum-7150/support-multiple-extensions
Nov 14, 2024
Merged
RUM-7150: Add multiple extension support #2384
jonathanmos
merged 2 commits into
feature/sr_compose
from
jmoskovich/rum-7150/support-multiple-extensions
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2384 +/- ##
======================================================
- Coverage 69.76% 69.65% -0.12%
======================================================
Files 774 773 -1
Lines 28790 28806 +16
Branches 4889 4893 +4
======================================================
- Hits 20085 20062 -23
- Misses 7351 7371 +20
- Partials 1354 1373 +19
|
ambushwork
reviewed
Nov 12, 2024
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Outdated
Show resolved
Hide resolved
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Outdated
Show resolved
Hide resolved
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Outdated
Show resolved
Hide resolved
...y/src/test/kotlin/com/datadog/android/sessionreplay/SessionReplayConfigurationBuilderTest.kt
Outdated
Show resolved
Hide resolved
e4ba5ba
to
9a9b3db
Compare
ambushwork
previously approved these changes
Nov 13, 2024
9a9b3db
to
80ff449
Compare
The base branch was changed.
ambushwork
previously approved these changes
Nov 13, 2024
Well done ! |
0xnm
reviewed
Nov 13, 2024
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Outdated
Show resolved
Hide resolved
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Outdated
Show resolved
Hide resolved
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Outdated
Show resolved
Hide resolved
80ff449
to
69448ce
Compare
0xnm
reviewed
Nov 13, 2024
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Outdated
Show resolved
Hide resolved
99df836
to
27e8175
Compare
27e8175
to
2cbb9c1
Compare
0xnm
previously approved these changes
Nov 13, 2024
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Outdated
Show resolved
Hide resolved
...y/src/test/kotlin/com/datadog/android/sessionreplay/SessionReplayConfigurationBuilderTest.kt
Outdated
Show resolved
Hide resolved
ambushwork
previously approved these changes
Nov 13, 2024
0xnm
reviewed
Nov 13, 2024
features/dd-sdk-android-session-replay/api/dd-sdk-android-session-replay.api
Outdated
Show resolved
Hide resolved
0xnm
previously approved these changes
Nov 13, 2024
features/dd-sdk-android-session-replay/api/dd-sdk-android-session-replay.api
Outdated
Show resolved
Hide resolved
cc420bf
to
2caecac
Compare
0xnm
reviewed
Nov 14, 2024
...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Show resolved
Hide resolved
2caecac
to
6e09dbf
Compare
0xnm
approved these changes
Nov 14, 2024
ambushwork
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support for adding multiple extensions to the session replay configuration.
• If the same extension is added twice we print an error message.
• If several extensions map to the same type we use the first occurrence and print an error message.
Motivation
This will probably be a commonly required use-case.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)