Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env tag in benchmark metrics #2276

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

ambushwork
Copy link
Member

What does this PR do?

Add env tag in benchmark metrics

Motivation

To separate debug test metrics and release metrics

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork requested review from a team as code owners September 23, 2024 11:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (91a98e4) to head (c546b72).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2276      +/-   ##
===========================================
- Coverage    70.18%   69.97%   -0.21%     
===========================================
  Files          732      732              
  Lines        27227    27226       -1     
  Branches      4580     4579       -1     
===========================================
- Hits         19107    19050      -57     
- Misses        6863     6889      +26     
- Partials      1257     1287      +30     

see 29 files with indirect coverage changes

@ambushwork ambushwork merged commit 26c28e2 into develop Sep 23, 2024
23 checks passed
@ambushwork ambushwork deleted the yl/metrics/add-env-tag branch September 23, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants