Feature/session-replay/compound-button-mappers #2120
Conversation
RUM:4717: Improve CheckableTextViewMapper
RUM-4715:SwitchCompat mapper improvement
| asyncJobStatusCallback = eq(mockAsyncJobStatusCallback), | ||
| clipping = eq(MobileSegment.WireframeClip()), | ||
| shapeStyle = eq(null), | ||
| border = eq(null), |
There was a problem hiding this comment.
minor: occurrences of eq(null) can be replaced by isNull()
| @@ -165,74 +211,22 @@ internal abstract class BaseSwitchCompatMapperTest : LegacyBaseWireframeMapperTe | |||
| assertThat(resolvedWireframes).isEqualTo(fakeTextWireframes) | |||
| } | |||
|
|
|||
| @Test | |||
| @RepeatedTest(10) | |||
There was a problem hiding this comment.
why are we repeating this test?
There was a problem hiding this comment.
because in the function forge generate random data, so I want to repeat the test so that it can cover maximum the case
| import org.mockito.kotlin.eq | ||
| import org.mockito.kotlin.mock | ||
| import org.mockito.kotlin.whenever | ||
|
|
||
| @ForgeConfiguration(value = ForgeConfigurator::class, seed = 0x27e4b032201e5L) |
There was a problem hiding this comment.
why are we passing this seed value?
There was a problem hiding this comment.
it was added by mistake, now removed
| @@ -39,40 +54,23 @@ internal class SwitchCompatMapperTest : BaseSwitchCompatMapperTest() { | |||
| ) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `M resolve the switch as wireframes W map() { checked }`() { | |||
| @RepeatedTest(8) | |||
There was a problem hiding this comment.
why are we repeating this test?
There was a problem hiding this comment.
because in the function forge generate random data, so I want to repeat the test so that it can cover maximum the case
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2120 +/- ##
===========================================
- Coverage 69.84% 69.46% -0.38%
===========================================
Files 715 715
Lines 26577 26588 +11
Branches 4457 4468 +11
===========================================
- Hits 18561 18467 -94
- Misses 6821 6895 +74
- Partials 1195 1226 +31
|
What does this PR do?
Merge feature branch of session replay compound button and switch compat mapper into develop
Motivation
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)