-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-3861 Update testing ci steps to limit OOM and memory usage #1986
Conversation
.codecov.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we remove codecov
? I find it useful, I rely on the data I receive for each PR to see the coverage change and if any files touched in the PR are not covered enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov was run as part of the kover
job that we agreed to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I'll do is replace the test:release with test:kover then
@@ -53,7 +53,7 @@ jobs: | |||
|
|||
# Manually build the java bytecode | |||
- name: Execute Gradle build | |||
run: ./gradlew assembleLibraries | |||
run: ./gradlew assembleLibrariesDebug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we still need to build both build types (because it is a security scan, it needs to cover everything) or at least release
build type instead of debug
, because release
is what will be used by the customer later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point I'll switch to release
CONTRIBUTING.md
Outdated
./gradlew assembleLibraries | ||
./gradlew assembleLibrariesDebug assembleLibrariesRelease |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's maybe still keep assembleLibraries
? it is for the local run, without the agent, so we can run everything at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
7bf4beb
to
7213c49
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1986 +/- ##
===========================================
+ Coverage 83.68% 83.73% +0.05%
===========================================
Files 487 487
Lines 17736 17726 -10
Branches 2663 2662 -1
===========================================
Hits 14842 14842
+ Misses 2167 2160 -7
+ Partials 727 724 -3 |
7213c49
to
c85c004
Compare
What does this PR do?
Updates our CI to