Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some sr integration tests temporarily due to flakiness #1941

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jonathanmos
Copy link
Member

@jonathanmos jonathanmos commented Mar 27, 2024

What does this PR do?

Temporarily disable some SR integration tests due to CI flakiness

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos marked this pull request as ready for review March 27, 2024 09:47
@jonathanmos jonathanmos requested review from a team as code owners March 27, 2024 09:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Merging #1941 (45ef22c) into develop (f3e10ae) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1941      +/-   ##
===========================================
- Coverage    83.39%   83.29%   -0.10%     
===========================================
  Files          483      483              
  Lines        17398    17407       +9     
  Branches      2593     2595       +2     
===========================================
- Hits         14509    14499      -10     
- Misses        2194     2199       +5     
- Partials       695      709      +14     

see 31 files with indirect coverage changes

@jonathanmos jonathanmos force-pushed the jmoskovich/disable-sr-integration-tests branch from 1e68d9d to 45ef22c Compare March 27, 2024 11:01
@jonathanmos jonathanmos changed the title Disable all sr integration tests temporarily due to flakiness Disable sr integration tests temporarily due to flakiness Mar 27, 2024
@jonathanmos jonathanmos changed the title Disable sr integration tests temporarily due to flakiness Disable some sr integration tests temporarily due to flakiness Mar 27, 2024
@jonathanmos jonathanmos merged commit 683db40 into develop Mar 27, 2024
23 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/disable-sr-integration-tests branch March 27, 2024 11:50
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants