Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3430: Fix application startup time regression #1935

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Mar 25, 2024

What does this PR do?

Fixes #1899.

The change in #1832 broke the application startup time measurement (which was bound to the first RUM event before), because with this change application startup time was dependent on the SDK init moment, which is not the correct way to measure it.

This change brings old behaviour back by ignoring SDK init event.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

Merging #1935 (8b59811) into develop (684f5b4) will increase coverage by 0.02%.
Report is 14 commits behind head on develop.
The diff coverage is 95.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1935      +/-   ##
===========================================
+ Coverage    83.31%   83.33%   +0.02%     
===========================================
  Files          481      481              
  Lines        17412    17413       +1     
  Branches      2588     2591       +3     
===========================================
+ Hits         14506    14510       +4     
- Misses        2195     2196       +1     
+ Partials       711      707       -4     
Files Coverage Δ
...d/rum/internal/domain/scope/RumApplicationScope.kt 93.48% <100.00%> (+3.07%) ⬆️
...g/android/rum/internal/domain/scope/RumRawEvent.kt 100.00% <ø> (ø)
.../android/rum/internal/monitor/DatadogRumMonitor.kt 84.84% <100.00%> (-0.42%) ⬇️
...droid/rum/internal/domain/scope/RumSessionScope.kt 96.30% <50.00%> (-0.45%) ⬇️

... and 27 files with indirect coverage changes

@0xnm 0xnm marked this pull request as ready for review March 26, 2024 09:39
@0xnm 0xnm requested review from a team as code owners March 26, 2024 09:39
@0xnm 0xnm force-pushed the nogorodnikov/rum-3430/fix-application-startup-time-regression branch from 57369ee to 8b59811 Compare March 27, 2024 09:41
@0xnm 0xnm merged commit fc5b9bf into develop Mar 27, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-3430/fix-application-startup-time-regression branch March 27, 2024 13:20
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lower than expected startup times since 2.6.0
5 participants