Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3302 detect full snapshot from webview sr #1908

Conversation

xgouchet
Copy link
Member

What does this PR do?

Sends the hasFullSnapshot properly when forwarding Webview session replay segments

@xgouchet xgouchet requested review from a team as code owners March 11, 2024 13:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Merging #1908 (c3b45d2) into feature/sr-web-view-support (731551f) will decrease coverage by 0.08%.
The diff coverage is 81.82%.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/sr-web-view-support    #1908      +/-   ##
===============================================================
- Coverage                        83.61%   83.53%   -0.08%     
===============================================================
  Files                              473      473              
  Lines                            16771    16739      -32     
  Branches                          2551     2549       -2     
===============================================================
- Hits                             14022    13982      -40     
- Misses                            2031     2040       +9     
+ Partials                           718      717       -1     
Files Coverage Δ
...sionreplay/internal/net/BatchesToSegmentsMapper.kt 74.49% <81.82%> (ø)

... and 29 files with indirect coverage changes

@xgouchet xgouchet merged commit dec970a into feature/sr-web-view-support Mar 11, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-3302/handle_has_full_snapshot branch March 11, 2024 14:06
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants