Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3338 Allow disabling ANR tracking #1889

Closed
wants to merge 1 commit into from

Conversation

xgouchet
Copy link
Member

What does this PR do?

Add a configuration option to disable ANR tracking in the RUM feature configuration.

Motivation

Our in-house ANR tracking provides information that are an estimation and not exactly the same as what the Google Play Store console reports. This makes it an optional feature to let customer disable it.

@xgouchet xgouchet requested review from a team as code owners February 26, 2024 08:04
@xgouchet xgouchet force-pushed the xgouchet/RUM-3338/disable_anr_tracking branch from 344df54 to 1f91e65 Compare February 26, 2024 08:12
@0xnm
Copy link
Member

0xnm commented Feb 26, 2024

This goes in parallel with the work about ANR changes (different way to detect them for Android 11 and above, introduction of fatal vs non-fatal ANRs which will bring new configuration method), so I would propose to wait a bit so that all these changes are aligned.

* Google Play Store.
* @param enabled whether ANR tracking should be enabled (default: true)
*/
fun trackApplicationNotResponding(enabled: Boolean): Builder {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need to add this also in the TelemetryConfiguration event ?

@0xnm
Copy link
Member

0xnm commented Mar 14, 2024

@xgouchet probably this one can be closed in favour of #1914

@xgouchet
Copy link
Member Author

Yep Agreed

@xgouchet xgouchet closed this Mar 15, 2024
@xgouchet xgouchet deleted the xgouchet/RUM-3338/disable_anr_tracking branch April 15, 2024 10:02
@xgouchet xgouchet added this to the Dropped milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants