RUM-1520 Single Feature Integration Tests: Trace #1786
Conversation
xgouchet
force-pushed
the
xgouchet/RUM-1520/single-fit-trace
branch
from
fb67c1f to
fb7b93a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1786 +/- ##
===========================================
- Coverage 83.47% 83.43% -0.04%
===========================================
Files 466 466
Lines 16364 16363 -1
Branches 2452 2452
===========================================
- Hits 13659 13652 -7
+ Misses 2039 2037 -2
- Partials 666 674 +8
|
xgouchet
force-pushed
the
xgouchet/RUM-1520/single-fit-trace
branch
from
fb7b93a to
e5f4527
Compare
xgouchet
force-pushed
the
xgouchet/RUM-1520/single-fit-trace
branch
from
e5f4527 to
8733d29
Compare
| @@ -65,7 +65,7 @@ internal class AndroidSpanLogsHandler( | |||
| timestampMicroseconds: Long? = null | |||
| ) { | |||
| val logsFeature = sdkCore.getFeature(Feature.LOGS_FEATURE_NAME) | |||
| if (logsFeature != null) { | |||
| if (logsFeature != null && fields.isNotEmpty()) { | |||
There was a problem hiding this comment.
Why this change is needed?
First, with this change we can have a false positive warning in LogCat about missing Logs features, when it is actually registered.
Second, we can have then a possibility to not send anything.
There was a problem hiding this comment.
Essentially this is to avoid sending a useless log: if the fields map is empty, then we will send a log with a default message (that just says "span log") with no custom attributes, providing no information whatsoever.
But indeed we might get a false positive logcat message, I'll fix that.
| * } | ||
| * } | ||
| */ | ||
| @Suppress("UnsafeThirdPartyFunctionCall") |
There was a problem hiding this comment.
should we exclude files under reliability from this check?
There was a problem hiding this comment.
Yes that makes more sense indeed.
.../single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/AndroidTracerTest.kt
Outdated
Show resolved
Hide resolved
reliability/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/SpanExt.kt
Outdated
Show resolved
Hide resolved
...le-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/TraceConfigurationTest.kt
Outdated
Show resolved
Hide resolved
...lity/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/UtilitiesTest.kt
Outdated
Show resolved
Hide resolved
...lity/single-fit/trace/src/test/kotlin/com/datadog/android/trace/integration/UtilitiesTest.kt
Outdated
Show resolved
Hide resolved
xgouchet
force-pushed
the
xgouchet/RUM-1520/single-fit-trace
branch
from
fdb40a7 to
988c2f2
Compare
What does this PR do?
Implement the Single-FIT layer of our new Test Pyramid for the trace module.