Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2446: Open text masking classes for extension #1757

Merged

Conversation

jonathanmos
Copy link
Member

What does this PR do?

Modify MaskTextViewMapper and MaskInputTextViewMapper to be open for extension.

Motivation

Necessary for React Native Session Replay, in order to support masking for text elements.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos changed the title Open text masking classes for extension RUM-2446: Open text masking classes for extension Dec 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023

Codecov Report

Merging #1757 (e9a2463) into develop (bece8a1) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1757      +/-   ##
===========================================
- Coverage    83.34%   83.29%   -0.05%     
===========================================
  Files          468      468              
  Lines        16304    16301       -3     
  Branches      2431     2430       -1     
===========================================
- Hits         13587    13577      -10     
- Misses        2050     2057       +7     
  Partials       667      667              
Files Coverage Δ
...nternal/recorder/mapper/MaskInputTextViewMapper.kt 80.00% <ø> (ø)
...lay/internal/recorder/mapper/MaskTextViewMapper.kt 100.00% <ø> (ø)

... and 23 files with indirect coverage changes

@jonathanmos jonathanmos marked this pull request as ready for review December 11, 2023 08:41
@jonathanmos jonathanmos requested review from a team as code owners December 11, 2023 08:41
@jonathanmos jonathanmos merged commit 538dd22 into develop Dec 11, 2023
@jonathanmos jonathanmos deleted the jmoskovich/rum-2446/open-text-masking-for-extension branch December 11, 2023 09:39
@xgouchet xgouchet added this to the 2.4.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants