Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test issues caused by git merge #1618

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

jonathanmos
Copy link
Member

What does this PR do?

Fix issue caused by git merge in one of the unit tests

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos requested a review from a team as a code owner September 14, 2023 14:20
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #1618 (649d806) into develop (a38fab8) will decrease coverage by 0.03%.
Report is 2 commits behind head on develop.
The diff coverage is 95.56%.

@@             Coverage Diff             @@
##           develop    #1618      +/-   ##
===========================================
- Coverage    83.57%   83.54%   -0.03%     
===========================================
  Files          452      452              
  Lines        15642    15649       +7     
  Branches      2325     2323       -2     
===========================================
+ Hits         13072    13073       +1     
- Misses        1951     1956       +5     
- Partials       619      620       +1     
Files Changed Coverage Δ
...replay/internal/processor/RecordedDataProcessor.kt 95.95% <80.00%> (+0.06%) ⬆️
...nreplay/internal/async/RecordedDataQueueHandler.kt 97.59% <100.00%> (ø)
...sionreplay/internal/async/RecordedDataQueueItem.kt 100.00% <100.00%> (ø)
...ay/internal/async/SnapshotRecordedDataQueueItem.kt 100.00% <100.00%> (ø)
.../internal/async/TouchEventRecordedDataQueueItem.kt 100.00% <100.00%> (ø)
...ay/internal/processor/RecordedQueuedItemContext.kt 100.00% <100.00%> (ø)
...replay/internal/processor/RumContextDataHandler.kt 100.00% <100.00%> (ø)
...eplay/internal/recorder/base64/Base64Serializer.kt 93.22% <100.00%> (-1.37%) ⬇️
...y/internal/recorder/base64/ImageWireframeHelper.kt 96.77% <100.00%> (+0.07%) ⬆️
...ay/internal/recorder/mapper/BaseWireframeMapper.kt 85.92% <100.00%> (+1.86%) ⬆️
... and 2 more

... and 22 files with indirect coverage changes

@jonathanmos jonathanmos merged commit b9b5bd5 into develop Sep 14, 2023
@jonathanmos jonathanmos deleted the jmoskovich/fix-rename-issues branch September 14, 2023 14:53
@xgouchet xgouchet added this to the 2.2.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants