Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apiSurface #1193

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Dec 14, 2022

What does this PR do?

After the recent merge from develop to feature/sdkv2 branch apiSurface files seems have been overwritten, fixing it by generating the proper ones (otherwise CI builds for feature/sdkv2 fail).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner December 14, 2022 08:57
@codecov-commenter
Copy link

Codecov Report

Merging #1193 (0d01461) into feature/sdkv2 (ac97bb0) will increase coverage by 0.08%.
The diff coverage is 89.68%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1193      +/-   ##
=================================================
+ Coverage          83.30%   83.38%   +0.08%     
=================================================
  Files                356      356              
  Lines              11969    11982      +13     
  Branches            2059     2059              
=================================================
+ Hits                9970     9991      +21     
- Misses              1356     1357       +1     
+ Partials             643      634       -9     
Impacted Files Coverage Δ
.../com/datadog/android/ktx/coroutine/CoroutineExt.kt 75.86% <ø> (ø)
.../kotlin/com/datadog/android/ktx/rum/ClosableExt.kt 100.00% <ø> (ø)
...om/datadog/android/ktx/sqlite/SqliteDatabaseExt.kt 92.86% <ø> (ø)
.../kotlin/com/datadog/android/ktx/tracing/SpanExt.kt 100.00% <ø> (+11.76%) ⬆️
...in/com/datadog/android/sqldelight/SqlDelightExt.kt 80.65% <ø> (ø)
...rnal/persistence/file/EncryptedFileReaderWriter.kt 93.75% <ø> (ø)
...ndroid/core/internal/persistence/file/FileMover.kt 62.96% <ø> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 88.24% <ø> (+1.96%) ⬆️
...al/persistence/file/single/SingleItemDataWriter.kt 95.83% <ø> (ø)
.../datadog/android/core/internal/thread/ThreadExt.kt 73.33% <ø> (ø)
... and 76 more

@0xnm 0xnm merged commit 044e33f into feature/sdkv2 Dec 14, 2022
@0xnm 0xnm deleted the nogorodnikov/update-api-surface-after-develop-into-sdkv2-merge branch December 14, 2022 09:28
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants