Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish task for the Session Replay module #1162

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Nov 25, 2022

What does this PR do?

This PR adds publish task for the Session Replay module, otherwise SNAPSHOT builds are broken currently.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 25, 2022 15:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #1162 (80e4d29) into develop (9e9d02f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1162      +/-   ##
===========================================
+ Coverage    82.22%   82.23%   +0.01%     
===========================================
  Files          353      353              
  Lines        11773    11773              
  Branches      2005     2005              
===========================================
+ Hits          9680     9681       +1     
+ Misses        1476     1474       -2     
- Partials       617      618       +1     
Impacted Files Coverage Δ
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 80.77% <0.00%> (-3.85%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 95.24% <0.00%> (-2.38%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 88.94% <0.00%> (-0.46%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.24% <0.00%> (-0.18%) ⬇️
...in/com/datadog/android/log/internal/LogsFeature.kt 88.71% <0.00%> (ø)
...android/log/internal/logger/TelemetryLogHandler.kt 85.71% <0.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.70% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <0.00%> (ø)
...android/log/internal/domain/DatadogLogGenerator.kt 96.62% <0.00%> (+0.68%) ⬆️
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (+0.86%) ⬆️
... and 2 more

@0xnm 0xnm merged commit 3e8b300 into develop Nov 25, 2022
@0xnm 0xnm deleted the nogorodnikov/add-publish-task-for-session-replay branch November 25, 2022 16:29
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants