-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2422 Process Session Replay touch and orientation change events #1014
Merged
mariusc83
merged 1 commit into
feature/session-replay-vo
from
mconstantin/rumm-2422/process-touchdata-and-orientation-change
Aug 31, 2022
Merged
RUMM-2422 Process Session Replay touch and orientation change events #1014
mariusc83
merged 1 commit into
feature/session-replay-vo
from
mconstantin/rumm-2422/process-touchdata-and-orientation-change
Aug 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## mconstantin/rumm-2421/process-snapshots-as-fullsnapshotrecords #1014 +/- ##
==================================================================================================
+ Coverage 83.09% 83.14% +0.05%
==================================================================================================
Files 320 320
Lines 10296 10334 +38
Branches 1697 1704 +7
==================================================================================================
+ Hits 8555 8592 +37
- Misses 1207 1208 +1
Partials 534 534
|
0xnm
approved these changes
Aug 25, 2022
@@ -25,6 +25,11 @@ data class SessionReplayRumContext( | |||
sessionId == NULL_UUID || | |||
viewId == NULL_UUID | |||
|
|||
internal fun isValid(): Boolean = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be simplified to !isNotValid
e82ac59
to
bbbc4e6
Compare
Base automatically changed from
mconstantin/rumm-2421/process-snapshots-as-fullsnapshotrecords
to
feature/session-replay-vo
August 31, 2022 12:54
6b72c53
to
147ccd7
Compare
mariusc83
added a commit
that referenced
this pull request
Sep 5, 2022
…ouchdata-and-orientation-change RUMM-2422 Process Session Replay touch and orientation change events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)