Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Monitoring Doc Edit #1010

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented Aug 8, 2022

What does this PR do?

Removes the view.loading_time metric.

Motivation

#rum-docs, #support-rum Slack

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@alai97 alai97 requested review from a team as code owners August 8, 2022 17:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #1010 (46f7b1f) into master (c3138f4) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
- Coverage   83.13%   83.11%   -0.01%     
==========================================
  Files         267      267              
  Lines        9079     9079              
  Branches     1461     1461              
==========================================
- Hits         7547     7546       -1     
- Misses       1131     1133       +2     
+ Partials      401      400       -1     
Impacted Files Coverage Δ
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (-1.72%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 94.48% <0.00%> (-0.61%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.07% <0.00%> (ø)
...ndroid/core/internal/persistence/file/EventMeta.kt 80.00% <0.00%> (ø)
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 88.46% <0.00%> (+1.92%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+25.00%) ⬆️

@alai97 alai97 merged commit 8a558ac into master Aug 10, 2022
@alai97 alai97 deleted the alai97/android-monitoring-data-collected-doc-edit branch August 10, 2022 18:32
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants