[forwarder] Allow configuration of multiple endpoints #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, adds some logging when the forwarder starts
gmmeyer
approved these changes
Jun 28, 2017
pkg/config/config.go
Outdated
| return keysPerDomain, err | ||
| } | ||
|
|
||
| for domain, apiKeys := range additionalEndpoints { |
There was a problem hiding this comment.
What happens if there is a domain without any keys? Should that throw an error or should we just be fine with it?
There was a problem hiding this comment.
we should probably log an error and discard that domain, I'll update the PR
pkg/config/config.go
Outdated
|
|
||
| for domain, apiKeys := range additionalEndpoints { | ||
| if _, ok := keysPerDomain[domain]; ok { | ||
| for _, apiKey := range apiKeys { |
There was a problem hiding this comment.
I think we should dedupe API Keys. What do you think?
There was a problem hiding this comment.
makes sense, I'll do that
* dedupe api keys and remove empty ones * discard domains that don't have an api key
`go lint` complains otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows configuration of multiple endpoints (implements related RFC).
Also, adds some logging when the forwarder starts.
Motivation
Support multiple endpoints. Needed for the agents running on our staging and prod infras.
Additional Notes
The endpoints configuration is not documented in the example
datadog.yamlsince I don't think we want to advertise this feature. To be confirmed though.