Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Some of our code is using webpack as a lib.
It was necessary a long time ago, but it's not anymore, if we refine a bit how we do things.
Also, vite can call the plugin's factory with no options apparently (discovered during reproduction).
Finally, also during reproduction, I got some errors related to the usage of
module
in our bundled lib.How?
module
detection).webpack
as a lib in the telemetry module.Fixes #91