Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-ui] Quick fixes for web-ui #145

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yoannmoinet
Copy link
Member

What and why?

Related to web-ui's integration.
Upgrading it to latest versions.
Some small fixes where necessary.

How?

  • esbuild: stub file was being removed too soon and sub builds would fail on resolution.
  • rspack: removal of stub file wasn't happening in case of failed build (using shutdown instead of done now).
  • rspack: re-organised the code to be all at the same place.
  • yarn cli prepare-link wasn't reverting to normal after a slight drift from package.json latest definition.

Follow-ups

Write a test that would catch the esbuild issue better.
The current test might be running too fast and doesn't reproduce the edge case well enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant