Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PF-2983]: Bump org.mockito:mockito-core from 4.8.0 to 5.10.0 #137

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 12, 2024

Bumps org.mockito:mockito-core from 4.8.0 to 5.10.0.

Release notes

Sourced from org.mockito:mockito-core's releases.

v5.10.0

Changelog generated by Shipkit Changelog Gradle Plugin

5.10.0

v5.9.0

What's Changed

New Contributors

Full Changelog: mockito/mockito@v5.8.0...v5.9.0

v5.8.0

Changelog generated by Shipkit Changelog Gradle Plugin

5.8.0

... (truncated)

Commits
  • 7e1bae8 Bump org.shipkit:shipkit-auto-version from 1.2.2 to 2.0.2 (#3248)
  • cf89d49 Bump org.assertj:assertj-core from 3.25.1 to 3.25.2 (#3247)
  • cc2ca36 Bump org.shipkit:shipkit-changelog from 1.2.0 to 2.0.1 (#3245)
  • ed01de6 Bump com.diffplug.spotless from 6.24.0 to 6.25.0 (#3244)
  • ef3dc8f Improve typing for PluginLoader#loadPlugin(..) (#3242)
  • 33dc48c Bump com.github.ben-manes.versions from 0.50.0 to 0.51.0 (#3241)
  • 9173522 Add support for static mocks on DoNotMockEnforcer (#3220)
  • a021436 Bump com.diffplug.spotless from 6.23.3 to 6.24.0 (#3236)
  • e4fa639 Align Javadoc configuration to Java 21 standards (#3230)
  • 71e2fdb Bump org.gradle.toolchains.foojay-resolver-convention (#3234)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot requested review from a team, cjllanwarne and LizBaldo and removed request for a team February 12, 2024 17:20
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 12, 2024

The following labels could not be found: dependency, gradle.

@cahrens cahrens marked this pull request as draft February 12, 2024 17:48
@cahrens
Copy link
Contributor

cahrens commented Feb 12, 2024

@dependabot rebase

Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 4.8.0 to 5.10.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.8.0...v5.10.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/develop/org.mockito-mockito-core-5.10.0 branch from bcf87e0 to d4f9752 Compare February 12, 2024 18:39
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cahrens cahrens marked this pull request as ready for review February 12, 2024 18:51
Copy link
Contributor

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any repo using TCL that are still on Java 8? If so this might break things as the minimum Java version supported by Mockito 5.X is now 11 .

Should this be a manual PR instead that would lead to a breaking change version bump?

Copy link

@cjllanwarne cjllanwarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that all JDK8 support is no longer needed. All tests look good

@cahrens
Copy link
Contributor

cahrens commented Feb 15, 2024

Please remember to click "Merge" when you are the second reviewer.

@cahrens cahrens merged commit 451b58b into develop Feb 15, 2024
2 checks passed
@cahrens cahrens deleted the dependabot/gradle/develop/org.mockito-mockito-core-5.10.0 branch February 15, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants