[CORE-178] Fix integration tests #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the CRL_JANITOR_CLIENT_SA_B64 secret since it no longer exists in vault
samanehsan
force-pushed
the
se/CORE-178-fix-crl-janitor-secret
branch
from
5f0c6f7 to
10e5299
Compare
samanehsan
force-pushed
the
se/CORE-178-fix-crl-janitor-secret
branch
from
9a706f1 to
9a6b607
Compare
samanehsan
commented
Nov 21, 2024
| | jq .data > $AZURE_MANAGED_APP_FILE | ||
| - name: Write Janitor Client SA file | ||
| run: | | ||
| JANITOR_SA_B64=${{ secrets.CRL_JANITOR_CLIENT_SA_B64 }} |
There was a problem hiding this comment.
This secret is no longer in vault so it gets handled separately
samanehsan
commented
Nov 21, 2024
| AZURE_MANAGED_APP_CLIENT_SECRET=$(jq -r '."client-secret"' ${AZURE_MANAGED_APP_CLIENT_FILE}) | ||
| AZURE_MANAGED_APP_TENANT_ID=$(jq -r '."tenant-id"' ${AZURE_MANAGED_APP_CLIENT_FILE}) | ||
| cat > ${AZURE_PROPERTIES_FILE} <<EOF | ||
| AZURE_MANAGED_APP_CLIENT_ID=$(jq -r '."client-id"' ${AZURE_MANAGED_APP_FILE}) |
There was a problem hiding this comment.
This step was getting cached by github actions, but I needed it to re-run after updating the client secret so I just renamed some of the env variables.
samanehsan
commented
Nov 21, 2024
| @@ -24,7 +24,7 @@ public class AzureIntegrationUtils { | |||
| "f557c728-871d-408c-a28b-eb6b2141a087", | |||
| AzureEnvironment.AZURE); | |||
|
|
|||
| public static final String DEFAULT_AZURE_RESOURCE_GROUP = "e2e-xmx74y"; | |||
| public static final String DEFAULT_AZURE_RESOURCE_GROUP = "DefaultResourceGroup-EUS2"; | |||
There was a problem hiding this comment.
The "e2e-xmx74y" test resource group no longer exists and was causing AzureResponseLoggerTest.testRecordEvent to fail
samanehsan
force-pushed
the
se/CORE-178-fix-crl-janitor-secret
branch
from
5a1672d to
6abe557
Compare
samanehsan
force-pushed
the
se/CORE-178-fix-crl-janitor-secret
branch
from
6abe557 to
12a4082
Compare
|
samanehsan
changed the title
davidangb
approved these changes
Nov 25, 2024
calypsomatic
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/CORE-178