Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a workaround for SegmentTimeline manifests for which there is no … #4658

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add a workaround for SegmentTimeline manifests for which there is no … #4658

merged 1 commit into from
Jan 8, 2025

Conversation

dsilhavy
Copy link
Collaborator

@dsilhavy dsilhavy commented Jan 8, 2025

…valid segment request to be found when seeking to the very end.

  • Adds a handler in the StreamProcessor to cover cases in which a seek to duration() is performed and no valid segment request could be found
  • Adds a functional test to make sure that ended event is thrown when seeking to duration() + offset

This fixes #4573

@dsilhavy
Add a workaround for SegmentTimeline manifests for which there is no …
6bf6b84 
…valid segment request to be found when seeking to the very end
@dsilhavy dsilhavy added this to the 5.0.0 milestone Jan 8, 2025
@dsilhavy dsilhavy merged commit 0d62e13 into development Jan 8, 2025
3 checks passed
@dsilhavy dsilhavy deleted the fix/4573 branch January 8, 2025 07:42
@dsilhavy dsilhavy mentioned this pull request Jan 8, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
dash.js Version 5.0.0
Status: Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Seeking beyond the end of the content causes the player to keep buffering and remain in a waiting state.
1 participant
@dsilhavy