Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues raised by @bbert on Slack:
ScheduleController
fastSwitchEnabled
option throughMediaPlayerModel
. By default, this setting is now set tonull
. In case the app is not setting an explicit value we default totrue
for normal playback andfalse
for low latency playback. In general, we should think about having adefault configuration
and auser provided configuration
to avoid setting values tonull
by default. The reason we are doing this right now is to understand when a setting has been explicitly set by the application or when it is simply an untouched default setting.