Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/low latency #4618

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Fix/low latency #4618

merged 7 commits into from
Nov 14, 2024

Conversation

dsilhavy
Copy link
Collaborator

@dsilhavy dsilhavy commented Nov 6, 2024

This PR addresses issues raised by @bbert on Slack:

  • When playing in low latency mode: Ignore the duration of the segment when determining whether a new segment request shall be scheduled or not. Otherwise, we delay fetching chunks in low latency mode. See changes in ScheduleController
  • Proxy the fastSwitchEnabled option through MediaPlayerModel. By default, this setting is now set to null. In case the app is not setting an explicit value we default to true for normal playback and false for low latency playback. In general, we should think about having a default configuration and a user provided configuration to avoid setting values to null by default. The reason we are doing this right now is to understand when a setting has been explicitly set by the application or when it is simply an untouched default setting.

@dsilhavy dsilhavy added this to the 5.0.0 milestone Nov 6, 2024
@dsilhavy dsilhavy requested a review from bbert November 6, 2024 15:12
@dsilhavy
Copy link
Collaborator Author

Merging this as potential additional changes will be made on top

@dsilhavy dsilhavy merged commit f747060 into development Nov 14, 2024
3 checks passed
@dsilhavy dsilhavy deleted the fix/lowLatency branch November 14, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant