Add matchSettingsId to mediaController #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Kalynov , thank you for your contribution. On behalf of which company are you providing this PR? Following our contribution guidelines, and since this seems to be your first PR, have you signed the feedback agreement yet? If not, can you please send me a signed copy of the dash.js feedback agreement? |
|
Hi
Yes, sure
In the attachment you can find the feedback agreement
Best Regards
Artem Kalynov
чт, 26 сент. 2024 г. в 09:15, Daniel Silhavy ***@***.***>:
… Hi @Kalynov <https://github.com/Kalynov> , thank you for your
contribution. On behalf of which company are you providing this PR?
Following our contribution guidelines
<https://github.com/Dash-Industry-Forum/dash.js/blob/development/CONTRIBUTING.md>,
and since this seems to be your first PR, have you signed the feedback
agreement yet? If not, can you please send me a signed copy of the dash.js feedback
agreement
<https://dashif.org/docs/DASH-IF-Feedback-Agreement-3-7-2014.pdf>?
—
Reply to this email directly, view it on GitHub
<#4576 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJFVALPV2NORGIOC3J62I7LZYOX7XAVCNFSM6AAAAABO4KH5ASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWGEYTOOBZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Kalynov I dont see any attachment, please send it to my mail |
dsilhavy
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set initial media settings using ID and filter tracks by their id.
This is necessary so that in the absence of other parameters (lang, index, viewPoint, role, accessibility, audioChannelConfig, codec) it was possible to uniquely initialize the track