Update liveCatchup.maxDrift logic to allow zero value. #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it possible to dissable catchup with seeking as described in the documentation.
|
Hi @BramB-1952444 , thank you for your contribution. On behalf of which company are you providing this PR? Following our contribution guidelines, and since this seems to be your first PR have you signed the feedback agreement yet? If not can you please send me a signed copy of the dash.js feedback agreement? |
|
Hi @dsilhavy I am a student at Hasselt University. Where can I send you the feedback agreement? |
|
@BramB-1952444 You can send it directly to my mail, I will forward. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible to disable catchup with seeking as described in the documentation.
Problem explained in issue #4527