Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript - externalManifest is optional for several methods. #4504

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

matvp91
Copy link
Contributor

@matvp91 matvp91 commented Jun 17, 2024

Found a few TS overrides in my code, they're better off being fixed upstream.

// Types that are missing or wrong in dashjs, should push this upstream too.
declare module "dashjs" {
  class DashAdapter {
    getAvailabilityStartTime(externalManifest?: object): number;
    getIsDynamic(externalManifest?: object): boolean;
    getDuration(externalManifest?: object): number;
  }
}

@dsilhavy dsilhavy self-requested a review June 18, 2024 13:27
@dsilhavy dsilhavy added this to the 5.0.0 milestone Jun 18, 2024
@dsilhavy dsilhavy merged commit 072206b into Dash-Industry-Forum:development Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants