Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override the minPlaybackRateChange check when newRate=1.0 #4481

Merged
merged 2 commits into from
May 17, 2024
Merged

Override the minPlaybackRateChange check when newRate=1.0 #4481

merged 2 commits into from
May 17, 2024

Conversation

piersoh
Copy link
Contributor

@piersoh piersoh commented May 17, 2024 •
edited
Loading

  • This avoids the situation where the playbackrate can get stuck at a non 1.0 rate, if the rate change is less than minPlaybackRateChange. If even a small non 1.0 playbackrate persists it leads to playback buffer and latency decrease (or increase) over time.

@piersoh
Bypass the minPlaybackRateChange check when newRate=1.0
15a22e8 
- This avoids the situation where the playbackrate can get stuck at non
  1.0 rate, due to the rate change being less than minPlaybackRateChange
@dsilhavy dsilhavy added this to the 5.0.0 milestone May 17, 2024
@dsilhavy dsilhavy merged commit 912c14c into Dash-Industry-Forum:development May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
dash.js Version 5.0.0
Status: Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@piersoh @dsilhavy