Fix/mpd patch #4457
Merged
Fix/mpd patch #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbert Please let me know if you think there is a better way to adjust the parser in order to access the elements in sequential order. I keep this PR open to verify the patching functionality once there has been a small fix in the LiveSim reference sreams. See here for details: Dash-Industry-Forum/livesim2#174 (comment) |
|
Also fixed a bug that caused the startNumber to be treated as a string. This lead to string concatenation of numbers instead of doing a "normal" addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4452
tXml.jsadd__childrenfor each object to have the possibility to access the elements in the original order. This is important for MPD patching as operations need to happen sequentiallytXml.jskeep thetagNamefor each node to be able to identify the type of the node in__childrenPatchManifestModelbased on the changes described above.