change customCapabilitiesFilter to accept async function #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omCapFilters' change customCapabilitiesFilter to accept async function See merge request standards2/dlb_dash.js!8
dsilhavy
requested changes
Apr 15, 2024
|
Thanks @stschr for quickly addressing the comments. Can you please merge the latest changes from development then I can merge your PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in one of our previous sync calls, I changed the customCapabilitiesFilter callback to accept async functions as required by e.g. MCA.
I also added a sample for this as I'm not aware of any other place where the feature could get exemplified.