Fix TS typings for KeyErrorEvent and KeySessionCreatedEvent error #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like it may be worthwhile to also remove |
kris-youview
force-pushed
the
kris/key-error-typings
branch
from
ee8ab6d to
06827f5
Compare
Removed it as it seems unused now. |
`KeyErrorEvent` is triggered with `error` (`DashJSError`) instead of `data`. `KeySystemSelectedEvent` has incorrect `error` type: it's `DashJSError` as well instead of `string`. As a result, `KeyError` type becomes redundant and can be removed.
kris-youview
force-pushed
the
kris/key-error-typings
branch
from
06827f5 to
eecb9cd
Compare
dsilhavy
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyErrorEventis triggered witherror(DashJSError) instead ofdata.KeySystemSelectedEventhas incorrecterrortype: it'sDashJSErroras well instead ofstring.As a result,
KeyErrortype becomes redundant and can be removed.Context
KeyErrorEventis triggered here:https://github.com/search?q=repo%3ADash-Industry-Forum%2Fdash.js+path%3A%2Fsrc%2Fstreaming%2Fprotection%2Fmodels%2F*+KEY_ERROR&type=code
KeySystemSelectedEventis triggered here:https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/protection/controllers/ProtectionController.js#L249