Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descriptor type updates v5.0.0 #4250

Conversation

stschr
Copy link
Contributor

@stschr stschr commented Aug 4, 2023

#4205

This PR addresses:

  • settings structure is kept as close as possible with previous version; if used as with v4.x, default schemeIdUri are assumed
  • no changes to selection logic except that schemeIdUri are compared as well
  • deprecates old elements and uses descriptorType elements only
  • updated/cleaned unit test

Let's discuss some details in next week's call (2023-08-10).

@dsilhavy dsilhavy added this to the 5.0.0 milestone Aug 11, 2023
@dsilhavy dsilhavy self-requested a review August 11, 2023 12:29
@stschr
Copy link
Contributor Author

stschr commented Aug 11, 2023

Another observation:
I just figured out that sample "Multiple Language Timed Text Sample" ist no longer working - due to a wrong schemeIdUri in the MPD (it uses <Role schemeIdUri="urn:mpeg:dash:role" value="subtitle" /> - note the missing year :2011 at the end of the schemeIdUri - interesting: this is not detected by the conformance validator).

I could either:

  • update the sample to explicitly set the invalid schemeIdUri
  • keep the sample "as is" (which would require to update the MPD)

@dsilhavy
Copy link
Collaborator

Another observation: I just figured out that sample "Multiple Language Timed Text Sample" ist no longer working - due to a wrong schemeIdUri in the MPD (it uses <Role schemeIdUri="urn:mpeg:dash:role" value="subtitle" /> - note the missing year :2011 at the end of the schemeIdUri - interesting: this is not detected by the conformance validator).

I could either:

  • update the sample to explicitly set the invalid schemeIdUri
  • keep the sample "as is" (which would require to update the MPD)

Thanks, for means of completion this is the wrong MPD: https://dash.akamaized.net/dash264/TestCases/4b/qualcomm/1/ED_OnDemand_5SecSeg_Subtitles.mpd . We should fix the MPD. The default sample MPD https://livesim.dashif.org/dash/vod/testpic_2s/multi_subs.mpd should still work.

@stschr stschr force-pushed the stschr_v5.0.0_descriptorType_updates branch from f407386 to d0aaf3f Compare August 11, 2023 14:38
@stschr stschr marked this pull request as ready for review August 11, 2023 14:38
@dsilhavy dsilhavy merged commit 50af3de into Dash-Industry-Forum:v5.0.0 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants