Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Autosave RAW" setting to sub-ghz app. #561

Closed

Conversation

CodyTolene
Copy link
Contributor

@CodyTolene CodyTolene commented Jul 28, 2023

Not sure if we should make this a part of unleashed, or the main firmware? Or at all? I'm not even sure if this is even a good idea yet but wanted to get this PR out to get an opinion on it as I tinker with it. Feel free to share thoughts, thanks all.

Edit: Side note, I'm also interested in maybe combining with the below work was well. Maybe as a new app?

flipperdevices/flipperzero-firmware#1667

What's new

  • Autosave sub-ghz RAW data. Intention: bypass 55 capture/heap size max limits.

Verification

  • In "Sub-GHz" application read & capture RAW, see autosave function.

Todo

  • Add new "Autosave RAW" setting.
  • Autosave captures when setting is "On".
  • Default functionality when setting is "Off".

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@CodyTolene CodyTolene changed the title Add autosave setting to subghz app. Add "Autosave RAW" setting to sub-ghz app. Jul 28, 2023
@@ -1,7 +1,7 @@
App(
appid="subghz",
name="Sub-GHz",
apptype=FlipperAppType.APP,
apptype=FlipperAppType.EXTERNAL,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary for testing. Todo: Revert.

@xMasterX
Copy link
Member

xMasterX commented Jul 28, 2023

Hi, please make it as separate external app, not in main subghz app for now, you can copy subghz app since its already prepared to be external / or make subghz external in this PR
we have discussed this feature multiple times with our team, and found that it can't be done without affecting performance of receiver, but since you already started work on it, if you want to continue make it as second external app, if all goes well this will be merged into main app,
or just make subghz external again so you will see how much ram we have in result
subghz currently moved into internal since we have not enough ram for signals
but if you could make something like "swap file" in regular os, but for subghz in flipper firmware, it will solve that issue

@CodyTolene CodyTolene closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants