Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fds to show version with fds version #89

Merged
merged 2 commits into from
Aug 14, 2021
Merged

Add fds to show version with fds version #89

merged 2 commits into from
Aug 14, 2021

Conversation

mohithg
Copy link
Contributor

@mohithg mohithg commented Aug 14, 2021

image

@mohithg mohithg requested review from guysmoilov and deanp70 August 14, 2021 10:52
@mohithg mohithg self-assigned this Aug 14, 2021
@mohithg mohithg linked an issue Aug 14, 2021 that may be closed by this pull request
Implement fds -V or fds --version #86
Closed
@deanp70
Copy link
Member

deanp70 commented Aug 14, 2021

Only thing is we need to bump the package version

@guysmoilov
Copy link
Member

@deanp70 First we merge the PR, then we bump the package version later when we went to deploy that latest version from the main branch

@guysmoilov guysmoilov merged commit 4e7b763 into main Aug 14, 2021
@guysmoilov guysmoilov deleted the mohithg/fds-version branch August 14, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysmoilov guysmoilov guysmoilov approved these changes

@deanp70 deanp70 deanp70 approved these changes

Assignees

@mohithg mohithg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement fds -V or fds --version
3 participants
@mohithg @deanp70 @guysmoilov