Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the style of the context menu of ActivityBarItem #613

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

kiwiwong
Copy link
Collaborator

Description

Fix the style of the context menu of ActivityBarItem.

Fixes #577

Changes

  • Replace DropDown with contextView to display ActivityBarItem's context menu.

@kiwiwong kiwiwong added the bug Something isn't working label Jan 11, 2022
@kiwiwong kiwiwong self-assigned this Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #613 (53dd7b2) into main (b11b4e9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   87.28%   87.32%   +0.03%     
==========================================
  Files         190      190              
  Lines        5578     5577       -1     
  Branches     1243     1241       -2     
==========================================
+ Hits         4869     4870       +1     
+ Misses        699      697       -2     
  Partials       10       10              
Impacted Files Coverage Δ
src/workbench/activityBar/activityBarItem.tsx 100.00% <100.00%> (ø)
src/common/dom.ts 83.58% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b11b4e9...53dd7b2. Read the comment docs.

@wewoor wewoor added this to the Next Version milestone Jan 11, 2022
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个修改有测试 Storybook 里面的场景吗?

@wewoor wewoor changed the title fix: fix the style of the context menu of ActivityBarItem fix: the style of the context menu of ActivityBarItem Jan 11, 2022
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 08fd30f into main Jan 11, 2022
@wewoor wewoor deleted the fix/activityBarItem branch January 11, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the style of global ActivityBar is incorrect
2 participants