Merge pull request #683 from DHI/types42

More type hints - No untyped defs

.vscode/settings.json

@@ -11,6 +11,6 @@
     "python.formatting.provider": "black",
     "editor.formatOnSave": true,
     "mypy-type-checker.args": [
-        "--disallow-incomplete-defs",
+        "--disallow-untyped-defs",
     ],
 }

mikeio/__init__.py

@@ -52,7 +52,7 @@ def read(
     items: str | int | Sequence[str | int] | None = None,
     time: int | str | slice | None = None,
     keepdims: bool = False,
-    **kwargs,
+    **kwargs: Any,
 ) -> Dataset:
     """Read all or a subset of the data from a dfs file
 

mikeio/_track.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 from pathlib import Path
 from collections.abc import Sequence
-from typing import Callable, Tuple
+from typing import Any, Callable, Tuple
 
 import numpy as np
 import pandas as pd
@@ -25,7 +25,7 @@ def _extract_track(
     time_steps: Sequence[int],
     n_elements: int,
     method: str,
-    dtype,
+    dtype: Any,  # TODO DTypeLike?
     data_read_func: Callable[[int, int], Tuple[np.ndarray, float]],
 ) -> Dataset:
 
@@ -119,7 +119,7 @@ def _extract_track(
         d[d == deletevalue] = np.nan
         d2[i, :] = d
 
-    def is_EOF(step):
+    def is_EOF(step: int) -> bool:
         return step >= len(time_steps)
 
     # loop over track points