-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(236242): Run contentful tests on PR (code-pr.check.yml) & added unit tests for contentful-migrations #981
Merged
jag-nahl-airelogic
merged 16 commits into
development
from
task/run-contentful-tests-on-pr
Mar 5, 2025
Merged
feat(236242): Run contentful tests on PR (code-pr.check.yml) & added unit tests for contentful-migrations #981
jag-nahl-airelogic
merged 16 commits into
development
from
task/run-contentful-tests-on-pr
Mar 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entful-tests-on-pr
DrewAire
approved these changes
Feb 27, 2025
KendLawrie
reviewed
Mar 3, 2025
KendLawrie
approved these changes
Mar 3, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses ticket #236242
This runs the contentful JEST tests (only when changes within /contentful directory) in directory /contentful when a PR has been created or on push to a PR.
To maintain one file for our PR based actions we have to skip over specific steps in the job as we need to check within the job if any files have changed.
Changes
Major
Minor
How to review the PR
You will have to change the PR to include specific branches for Code-Pr-Check.yml to run. I have already done the tests and you can view the results below.
No changes to contentful directory:
Github Action Run
PR
Changes to contentful directory:
Github Action Run
Test Report
PR
Ignore the other unit test fail - that was a change to the code base to see if the job would run.
Release requirements
Once merged into main, it will be done.
Checklist
Delete any rows that do not apply to the PR.