Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/fix unit test #961

Merged
merged 29 commits into from
Feb 3, 2025
Merged

Hotfix/fix unit test #961

merged 29 commits into from
Feb 3, 2025

Conversation

DrewAire
Copy link
Collaborator

@DrewAire DrewAire commented Feb 3, 2025 •
edited
Loading

Overview

Noticed a unit test was failing due to a mismatch between "Sep" and "Sept" (for September).

This also does the merge from development into main for the staging release.

katie-gardner and others added 25 commits January 17, 2025 14:11
@katie-gardner
docs: Add key locations to terraform readme
18312f5
@katie-gardner
Merge branch 'development' into docs/add-key-locations-to-tf-readme
3d9fedd
@jimwashbrook
fix(contentful): Fix various export-processor bugs, add more logging …
4bf82a5 
…+ JSDocs
Add/update terraform docs
d58c47c
@gilaineyo
chore: adds LF end-of-line and associated settings
3974bba
@katie-gardner
Merge branch 'development' into docs/add-key-locations-to-tf-readme
b452ba6
@katie-gardner
Merge pull request #950 from DFE-Digital/docs/add-key-locations-to-tf…
816314e 
…-readme

docs: Add secret locations to terraform readme
@gilaineyo
Merge branch 'development' into chore/236403/line-endings-editorconfig
4115bed
bug: 237416 Change code to reference UsePreviewApi variable
ec20888
@gilaineyo
Merge pull request #953 from DFE-Digital/chore/236403/line-endings-ed…
7137162 
…itorconfig

chore(236403): add line endings to .editorconfig
@jag-nahl-airelogic
246010 - Typo fix on the word assessment.
2efcf0c
@jag-nahl-airelogic
Merge pull request #955 from DFE-Digital/bug/typo-fix-link
d83586e 
fix(246010) - Typo fix on the word assessment.
@DrewAire
Merge branch 'development' into docs/update-terraform-docs
4d31005
@DrewAire @katie-gardner
Update terraform/container-app/README.md
25c0ab6 
Co-authored-by: Katie Gardner <114991656+katie-gardner@users.noreply.github.com>
@DrewAire
Merge branch 'development' into bug/237416-use-preview-environment-va…
8382053 
…riable
@DrewAire
Merge pull request #952 from DFE-Digital/docs/update-terraform-docs
b19ae19 
Add/update terraform docs
@DrewAire
Merge branch 'development' into bug/237416-use-preview-environment-va…
bac5b85 
…riable
@DrewAire
Merge pull request #954 from DFE-Digital/bug/237416-use-preview-envir…
d9f1722 
…onment-variable

fix (237416): use preview environment variable
@KendLawrie
added update and tests
d17dc15
@github-actions
chore: Linted code for plan-technology-for-your-school.sln solution
ed9670d
@KendLawrie
added comment
95a4851
@KendLawrie
Merge branch 'feat/244053/NonBreakingHyphen' of https://github.com/DF…
dad82f9 
…E-Digital/sts-plan-technology-for-your-school into feat/244053/NonBreakingHyphen
@KendLawrie
updated parameter
5a759fe
@DrewAire
Merge pull request #958 from DFE-Digital/feat/244053/NonBreakingHyphen
43508c7 
Replace standard Hyphens with non breaking hyphens
Update expected date string for FormattedDateShort_Should_Display_Cor…
86bfb12 
…rectly
jag-nahl-airelogic
jag-nahl-airelogic approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@jag-nahl-airelogic jag-nahl-airelogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output 


Warnings:

- Argument is deprecated
  on providers.tf line 4
- Attribute Deprecated
  on providers.tf line 4

To see the full warning notes, run Terraform without -compact-warnings.
Success! The configuration is valid, but there were some validation warnings
as shown above.

Terraform Plan 📖success

Pusher: @DrewAire, Action: pull_request, Working Directory: terraform/container-app, Workflow: Terraform PR Check

@DrewAire DrewAire force-pushed the hotfix/fix-unit-test branch from ce946f9 to b5397dc Compare February 3, 2025 11:07
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DrewAire DrewAire merged commit aef8f95 into main Feb 3, 2025
14 checks passed
@DrewAire DrewAire deleted the hotfix/fix-unit-test branch February 3, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jag-nahl-airelogic jag-nahl-airelogic jag-nahl-airelogic approved these changes

@KendLawrie KendLawrie KendLawrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DrewAire @jag-nahl-airelogic @KendLawrie @katie-gardner @jimwashbrook @gilaineyo