Release: development into main

[Iain-Stanger]

• Release V1.6.0

[github-actions]

SQL Risks Found

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSprocFix.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSprocFix.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: alter procedure getsectionstatuses @splitstringval nvarchar(255) as declare @val
nvarchar(50) create table #splittable(val nvarchar(50)) create table
#returntable(sectionid nvarchar(50), completed int, maturity nvarchar(20),
datecreated datetime) insert into #splittable select * from
string_split(@splitstringval, ',') declare db_cursor cursor for select val from
#splittable open db_cursor fetch next from db_cursor into @val while
@@fetch_status = 0 begin insert into #returntable select top 1 sectionid,
completed, maturity, datecreated from submission where sectionid = @val order by
datecreated desc fetch next from db_cursor into @val end close db_cursor
deallocate db_cursor select * from #returntable;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSprocFix.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 8, 28]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230921_1150_DeleteAnalyticsUser.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230921_1150_DeleteAnalyticsUser.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: if exists (select * from sys.database_principals where name = 'analyticsuser')
begin drop user [analyticsuser] end;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230921_1150_DeleteAnalyticsUser.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at line 1]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230922_1420_UpdateGetSectionStatusToAcceptEstablishmentId.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230922_1420_UpdateGetSectionStatusToAcceptEstablishmentId.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: alter procedure getsectionstatuses @splitstringval nvarchar(255),
@establishmentid int as declare @val nvarchar(50) create table #splittable(val
nvarchar(50)) create table #returntable(sectionid nvarchar(50), completed int,
maturity nvarchar(20), datecreated datetime) insert into #splittable select *
from string_split(@splitstringval, ',') declare db_cursor cursor for select val
from #splittable open db_cursor fetch next from db_cursor into @val while
@@fetch_status = 0 begin insert into #returntable select top 1 sectionid,
completed, maturity, datecreated from submission where sectionid = @val and
establishmentid = @establishmentid order by datecreated desc fetch next from
db_cursor into @val end close db_cursor deallocate db_cursor select * from
#returntable;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230922_1420_UpdateGetSectionStatusToAcceptEstablishmentId.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 10, 31]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230718_168650_GetSectionStatusesSproc.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230718_168650_GetSectionStatusesSproc.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: create procedure getsectionstatuses @splitstringval nvarchar(255) as declare
@val nvarchar(50) create table #splittable(val nvarchar(50)) create table
#returntable(sectionid nvarchar(50), completed int) insert into #splittable
select * from string_split(@splitstringval, ',') declare db_cursor cursor for
select val from #splittable open db_cursor fetch next from db_cursor into @val
while @@fetch_status = 0 begin insert into #returntable select top 1 sectionid,
completed from submission where sectionid = @val order by datecreated desc fetch
next from db_cursor into @val end close db_cursor deallocate db_cursor select *
from #returntable;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230718_168650_GetSectionStatusesSproc.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 8, 29]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230913_1224_UpdateSubmissionNullability.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230913_1224_UpdateSubmissionNullability.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: begin tran select id into #submissionids from [dbo].[submission] where sectionid
is null or sectionname is null delete from [dbo].[response] where exists (select
* from #submissionids where submissionid = #submissionids.id) delete from
[dbo].[submission] where sectionid is null or sectionname is null alter table
[dbo].[submission] alter column [sectionid] [nvarchar](50) not null alter table
[dbo].[submission] alter column [sectionname] [nvarchar](50) not null alter
table [dbo].[submission] drop column [recomendationid] commit tran;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230913_1224_UpdateSubmissionNullability.sql]: (HIGH RISK) (LOGICAL_DATABASE_DESIGN ANTI-PATTERN) Generic Primary Key
[Matching Expression: id at line 2]

[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230913_1224_UpdateSubmissionNullability.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at line 4]


==================== Summary ===================
All Anti-Patterns and Hints  :: 2
>  High Risk   :: 2
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSproc.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSproc.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: alter procedure getsectionstatuses @splitstringval nvarchar(255) as declare @val
nvarchar(50) create table #splittable(val nvarchar(50)) create table
#returntable(sectionid nvarchar(50), completed int) insert into #splittable
select * from string_split(@splitstringval, ',') declare db_cursor cursor for
select val from #splittable open db_cursor fetch next from db_cursor into @val
while @@fetch_status = 0 begin insert into #returntable select top 1 sectionid,
completed, maturity, datecreated from submission where sectionid = @val order by
datecreated desc fetch next from db_cursor into @val end close db_cursor
deallocate db_cursor select * from #returntable;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSproc.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 8, 29]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240111_0919_CreateAllRichTextContentForPageSlugFunction.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240111_0919_CreateAllRichTextContentForPageSlugFunction.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 2: create function [contentful].[selectallrichtextcontentforpageslug] ( @pageslug
nvarchar(max) ) returns @returntable table(id bigint, [value] nvarchar(max),
nodetype nvarchar(max), dataid bigint, parentid bigint) begin declare
@contentcomponentids table (id nvarchar(max)) declare @richtextids table (id
nvarchar(max)) insert into @contentcomponentids select
concat([beforecontentcomponentid], [contentcomponentid]) contentcomponentid from
[contentful].[pagecontents] pc left join [contentful].[pages] p on pc.pageid =
p.id where p.slug = @pageslug insert into @richtextids select richtextid from
[contentful].[textbodies] where id in (select * from @contentcomponentids) union
select richtextid from [contentful].[warnings] as w left join
[contentful].[textbodies] as tb on w.textid = tb.id where w.id in (select * from
@contentcomponentids) declare @idcolumn int select @idcolumn = min(id) from
@richtextids while @idcolumn is not null begin insert into @returntable select
[id], [value], [nodetype], [dataid], [parentid] from
[contentful].[selectallrichtextcontentforparentid](@idcolumn) select @idcolumn =
min(id) from @richtextids where id > @idcolumn end return end;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240111_0919_CreateAllRichTextContentForPageSlugFunction.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 16, 20]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240219_1407_FixWarningComponent.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240219_1407_FixWarningComponent.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: create or alter view [contentful].[richtextcontentsbyslug] as ( select [slug],
[id], [value], [nodetype], [dataid], [parentid], [published], [archived],
[deleted] from ( select [richtextid], [slug], [archived], [deleted], [published]
from ( --- get richtextids for all text bodies and warnings select [richtextid],
isnull([warning].[id], [tb].[id]) as contentid from [contentful].[textbodies] as
tb left join [contentful].warnings as warning on [warning].[textid] = [tb].[id]
) as richtexts left join --get all contents for a page ( select max([slug]) as
[slug], [contentid] from ( select isnull( [beforecontentcomponentid],
[contentcomponentid] ) as [contentid], [p].[slug] from
[contentful].[pagecontents] pc left join [contentful].[pages] p on [pc].[pageid]
= [p].[id] ) as pc group by [pc].[contentid] ) as contents on
[contents].[contentid] = [richtexts].[contentid] left join( select [id],
[archived], [published], [deleted] from [contentful].[contentcomponents] ) as cc
on [cc].[id] = [richtexts].[contentid] ) as richtextcontents outer apply (
select [id], [value], [nodetype], [dataid], [parentid] from
[contentful].[selectallrichtextcontentforparentid]([richtextcontents].[richtextid]) ) as richtextcontentswithslug );
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240219_1407_FixWarningComponent.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) JOIN Without Equality Check
[Matching Expression: join --get all contents for a page ( select max([slug]) as [slug], [contentid]
from ( select isnull( [beforecontentcomponentid], [contentcomponentid] ) as
[contentid], [p].[slug] from [contentful].[pagecontents] pc left at line 31]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240209_1647_CreateRichTextContentWithPageSlugView.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240209_1647_CreateRichTextContentWithPageSlugView.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: create or alter view [contentful].[richtextcontentsbyslug] as ( select [slug],
[id], [value], [nodetype], [dataid], [parentid], [published], [archived],
[deleted] from ( select [richtextid], [slug], [archived], [deleted], [published]
from ( --- get richtextids for all text bodies and warnings select [richtextid],
[id] as [contentid] from [contentful].[textbodies] as tb union select
[richtextid], [tb].[id] as [contentid] from [contentful].[warnings] as w left
join [contentful].[textbodies] as tb on [w].[textid] = [tb].[id] ) as richtexts
left join --get all contents for a page ( select max([slug]) as [slug],
[contentid] from ( select isnull( [beforecontentcomponentid],
[contentcomponentid] ) as [contentid], [p].[slug] from
[contentful].[pagecontents] pc left join [contentful].[pages] p on [pc].[pageid]
= [p].[id] ) as pc group by [pc].[contentid] ) as contents on
[contents].[contentid] = [richtexts].[contentid] left join( select [id],
[archived], [published], [deleted] from [contentful].[contentcomponents] ) as cc
on [cc].[id] = [richtexts].[contentid] ) as richtextcontents outer apply (
select [id], [value], [nodetype], [dataid], [parentid] from
[contentful].[selectallrichtextcontentforparentid]([richtextcontents].[richtextid]) ) as richtextcontentswithslug );
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240209_1647_CreateRichTextContentWithPageSlugView.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) JOIN Without Equality Check
[Matching Expression: join --get all contents for a page ( select max([slug]) as [slug], [contentid]
from ( select isnull( [beforecontentcomponentid], [contentcomponentid] ) as
[contentid], [p].[slug] from [contentful].[pagecontents] pc left at line 37]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/EnvironmentSpecificScripts/dev/2023/20230810_110900_DeleteDataForEstablishmentSproc.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/EnvironmentSpecificScripts/dev/2023/20230810_110900_DeleteDataForEstablishmentSproc.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: create procedure [dbo].[deletedataforestablishment] @establishmentref
nvarchar(50) as begin try begin tran declare @establishmentuid int declare
@rowsdeletedcount int select @establishmentuid = id from [dbo].[establishment]
where establishmentref = @establishmentref select id, establishmentid into
#submissionids from [dbo].[submission] where [submission].establishmentid =
@establishmentuid delete from[dbo].[response] where exists (select * from
#submissionids where [response].submissionid = #submissionids.id) delete from
[dbo].[submission] where [submission].establishmentid = @establishmentuid commit
tran return @@rowcount end try begin catch rollback tran return 0 end catch;
[./src/Dfe.PlanTech.DatabaseUpgrader/EnvironmentSpecificScripts/dev/2023/20230810_110900_DeleteDataForEstablishmentSproc.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at line 17]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

[sonarqubecloud]

Quality Gate passed

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

SQL Risks Found

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSprocFix.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSprocFix.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: alter procedure getsectionstatuses @splitstringval nvarchar(255) as declare @val
nvarchar(50) create table #splittable(val nvarchar(50)) create table
#returntable(sectionid nvarchar(50), completed int, maturity nvarchar(20),
datecreated datetime) insert into #splittable select * from
string_split(@splitstringval, ',') declare db_cursor cursor for select val from
#splittable open db_cursor fetch next from db_cursor into @val while
@@fetch_status = 0 begin insert into #returntable select top 1 sectionid,
completed, maturity, datecreated from submission where sectionid = @val order by
datecreated desc fetch next from db_cursor into @val end close db_cursor
deallocate db_cursor select * from #returntable;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSprocFix.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 8, 28]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230921_1150_DeleteAnalyticsUser.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230921_1150_DeleteAnalyticsUser.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: if exists (select * from sys.database_principals where name = 'analyticsuser')
begin drop user [analyticsuser] end;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230921_1150_DeleteAnalyticsUser.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at line 1]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230922_1420_UpdateGetSectionStatusToAcceptEstablishmentId.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230922_1420_UpdateGetSectionStatusToAcceptEstablishmentId.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: alter procedure getsectionstatuses @splitstringval nvarchar(255),
@establishmentid int as declare @val nvarchar(50) create table #splittable(val
nvarchar(50)) create table #returntable(sectionid nvarchar(50), completed int,
maturity nvarchar(20), datecreated datetime) insert into #splittable select *
from string_split(@splitstringval, ',') declare db_cursor cursor for select val
from #splittable open db_cursor fetch next from db_cursor into @val while
@@fetch_status = 0 begin insert into #returntable select top 1 sectionid,
completed, maturity, datecreated from submission where sectionid = @val and
establishmentid = @establishmentid order by datecreated desc fetch next from
db_cursor into @val end close db_cursor deallocate db_cursor select * from
#returntable;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230922_1420_UpdateGetSectionStatusToAcceptEstablishmentId.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 10, 31]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230718_168650_GetSectionStatusesSproc.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230718_168650_GetSectionStatusesSproc.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: create procedure getsectionstatuses @splitstringval nvarchar(255) as declare
@val nvarchar(50) create table #splittable(val nvarchar(50)) create table
#returntable(sectionid nvarchar(50), completed int) insert into #splittable
select * from string_split(@splitstringval, ',') declare db_cursor cursor for
select val from #splittable open db_cursor fetch next from db_cursor into @val
while @@fetch_status = 0 begin insert into #returntable select top 1 sectionid,
completed from submission where sectionid = @val order by datecreated desc fetch
next from db_cursor into @val end close db_cursor deallocate db_cursor select *
from #returntable;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230718_168650_GetSectionStatusesSproc.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 8, 29]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230913_1224_UpdateSubmissionNullability.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230913_1224_UpdateSubmissionNullability.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: begin tran select id into #submissionids from [dbo].[submission] where sectionid
is null or sectionname is null delete from [dbo].[response] where exists (select
* from #submissionids where submissionid = #submissionids.id) delete from
[dbo].[submission] where sectionid is null or sectionname is null alter table
[dbo].[submission] alter column [sectionid] [nvarchar](50) not null alter table
[dbo].[submission] alter column [sectionname] [nvarchar](50) not null alter
table [dbo].[submission] drop column [recomendationid] commit tran;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230913_1224_UpdateSubmissionNullability.sql]: (HIGH RISK) (LOGICAL_DATABASE_DESIGN ANTI-PATTERN) Generic Primary Key
[Matching Expression: id at line 2]

[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230913_1224_UpdateSubmissionNullability.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at line 4]


==================== Summary ===================
All Anti-Patterns and Hints  :: 2
>  High Risk   :: 2
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSproc.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSproc.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: alter procedure getsectionstatuses @splitstringval nvarchar(255) as declare @val
nvarchar(50) create table #splittable(val nvarchar(50)) create table
#returntable(sectionid nvarchar(50), completed int) insert into #splittable
select * from string_split(@splitstringval, ',') declare db_cursor cursor for
select val from #splittable open db_cursor fetch next from db_cursor into @val
while @@fetch_status = 0 begin insert into #returntable select top 1 sectionid,
completed, maturity, datecreated from submission where sectionid = @val order by
datecreated desc fetch next from db_cursor into @val end close db_cursor
deallocate db_cursor select * from #returntable;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2023/20230725_166107_ModifyGetSectionStatusesSproc.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 8, 29]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240111_0919_CreateAllRichTextContentForPageSlugFunction.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240111_0919_CreateAllRichTextContentForPageSlugFunction.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 2: create function [contentful].[selectallrichtextcontentforpageslug] ( @pageslug
nvarchar(max) ) returns @returntable table(id bigint, [value] nvarchar(max),
nodetype nvarchar(max), dataid bigint, parentid bigint) begin declare
@contentcomponentids table (id nvarchar(max)) declare @richtextids table (id
nvarchar(max)) insert into @contentcomponentids select
concat([beforecontentcomponentid], [contentcomponentid]) contentcomponentid from
[contentful].[pagecontents] pc left join [contentful].[pages] p on pc.pageid =
p.id where p.slug = @pageslug insert into @richtextids select richtextid from
[contentful].[textbodies] where id in (select * from @contentcomponentids) union
select richtextid from [contentful].[warnings] as w left join
[contentful].[textbodies] as tb on w.textid = tb.id where w.id in (select * from
@contentcomponentids) declare @idcolumn int select @idcolumn = min(id) from
@richtextids while @idcolumn is not null begin insert into @returntable select
[id], [value], [nodetype], [dataid], [parentid] from
[contentful].[selectallrichtextcontentforparentid](@idcolumn) select @idcolumn =
min(id) from @richtextids where id > @idcolumn end return end;
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240111_0919_CreateAllRichTextContentForPageSlugFunction.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at lines 16, 20]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240219_1407_FixWarningComponent.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240219_1407_FixWarningComponent.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: create or alter view [contentful].[richtextcontentsbyslug] as ( select [slug],
[id], [value], [nodetype], [dataid], [parentid], [published], [archived],
[deleted] from ( select [richtextid], [slug], [archived], [deleted], [published]
from ( --- get richtextids for all text bodies and warnings select [richtextid],
isnull([warning].[id], [tb].[id]) as contentid from [contentful].[textbodies] as
tb left join [contentful].warnings as warning on [warning].[textid] = [tb].[id]
) as richtexts left join --get all contents for a page ( select max([slug]) as
[slug], [contentid] from ( select isnull( [beforecontentcomponentid],
[contentcomponentid] ) as [contentid], [p].[slug] from
[contentful].[pagecontents] pc left join [contentful].[pages] p on [pc].[pageid]
= [p].[id] ) as pc group by [pc].[contentid] ) as contents on
[contents].[contentid] = [richtexts].[contentid] left join( select [id],
[archived], [published], [deleted] from [contentful].[contentcomponents] ) as cc
on [cc].[id] = [richtexts].[contentid] ) as richtextcontents outer apply (
select [id], [value], [nodetype], [dataid], [parentid] from
[contentful].[selectallrichtextcontentforparentid]([richtextcontents].[richtextid]) ) as richtextcontentswithslug );
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240219_1407_FixWarningComponent.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) JOIN Without Equality Check
[Matching Expression: join --get all contents for a page ( select max([slug]) as [slug], [contentid]
from ( select isnull( [beforecontentcomponentid], [contentcomponentid] ) as
[contentid], [p].[slug] from [contentful].[pagecontents] pc left at line 31]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240209_1647_CreateRichTextContentWithPageSlugView.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240209_1647_CreateRichTextContentWithPageSlugView.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: create or alter view [contentful].[richtextcontentsbyslug] as ( select [slug],
[id], [value], [nodetype], [dataid], [parentid], [published], [archived],
[deleted] from ( select [richtextid], [slug], [archived], [deleted], [published]
from ( --- get richtextids for all text bodies and warnings select [richtextid],
[id] as [contentid] from [contentful].[textbodies] as tb union select
[richtextid], [tb].[id] as [contentid] from [contentful].[warnings] as w left
join [contentful].[textbodies] as tb on [w].[textid] = [tb].[id] ) as richtexts
left join --get all contents for a page ( select max([slug]) as [slug],
[contentid] from ( select isnull( [beforecontentcomponentid],
[contentcomponentid] ) as [contentid], [p].[slug] from
[contentful].[pagecontents] pc left join [contentful].[pages] p on [pc].[pageid]
= [p].[id] ) as pc group by [pc].[contentid] ) as contents on
[contents].[contentid] = [richtexts].[contentid] left join( select [id],
[archived], [published], [deleted] from [contentful].[contentcomponents] ) as cc
on [cc].[id] = [richtexts].[contentid] ) as richtextcontents outer apply (
select [id], [value], [nodetype], [dataid], [parentid] from
[contentful].[selectallrichtextcontentforparentid]([richtextcontents].[richtextid]) ) as richtextcontentswithslug );
[./src/Dfe.PlanTech.DatabaseUpgrader/Scripts/2024/20240209_1647_CreateRichTextContentWithPageSlugView.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) JOIN Without Equality Check
[Matching Expression: join --get all contents for a page ( select max([slug]) as [slug], [contentid]
from ( select isnull( [beforecontentcomponentid], [contentcomponentid] ) as
[contentid], [p].[slug] from [contentful].[pagecontents] pc left at line 37]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0

./src/Dfe.PlanTech.DatabaseUpgrader/EnvironmentSpecificScripts/dev/2023/20230810_110900_DeleteDataForEstablishmentSproc.sql

+-------------------------------------------------+
|                   SQLCHECK                      |
+-------------------------------------------------+
> RISK LEVEL    :: ONLY MEDIUM AND HIGH RISK ANTI-PATTERNS
> SQL FILE NAME :: ./src/Dfe.PlanTech.DatabaseUpgrader/EnvironmentSpecificScripts/dev/2023/20230810_110900_DeleteDataForEstablishmentSproc.sql
> COLOR MODE    :: DISABLED
> VERBOSE MODE  :: DISABLED
> DELIMITER     :: ;
-------------------------------------------------
==================== Results ===================

-------------------------------------------------
SQL Statement at line 1: create procedure [dbo].[deletedataforestablishment] @establishmentref
nvarchar(50) as begin try begin tran declare @establishmentuid int declare
@rowsdeletedcount int select @establishmentuid = id from [dbo].[establishment]
where establishmentref = @establishmentref select id, establishmentid into
#submissionids from [dbo].[submission] where [submission].establishmentid =
@establishmentuid delete from[dbo].[response] where exists (select * from
#submissionids where [response].submissionid = #submissionids.id) delete from
[dbo].[submission] where [submission].establishmentid = @establishmentuid commit
tran return @@rowcount end try begin catch rollback tran return 0 end catch;
[./src/Dfe.PlanTech.DatabaseUpgrader/EnvironmentSpecificScripts/dev/2023/20230810_110900_DeleteDataForEstablishmentSproc.sql]: (HIGH RISK) (QUERY ANTI-PATTERN) SELECT *
[Matching Expression: select * at line 17]


==================== Summary ===================
All Anti-Patterns and Hints  :: 1
>  High Risk   :: 1
>  Medium Risk :: 0
>  Low Risk    :: 0
>  Hints       :: 0