Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make error handling consistent #466

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: make error handling consistent #466

merged 1 commit into from
Jan 18, 2024

Conversation

jimwashbrook
Copy link
Contributor

  • Makes the error for a missing interstital page the same as if the slug was null

  • Removes ref keyword in places it was used in the same file as unnecessary

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jimwashbrook jimwashbrook merged commit 91c3b77 into development Jan 18, 2024
18 checks passed
@Iain-Stanger Iain-Stanger deleted the fix/throw-error-for-missing-section branch February 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uahussain12 uahussain12 uahussain12 approved these changes

@Zac-Digital Zac-Digital Zac-Digital approved these changes

@Iain-Stanger Iain-Stanger Awaiting requested review from Iain-Stanger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimwashbrook @uahussain12 @Zac-Digital