Fixed more tests

DFE-Digital · Feb 27, 2025 · 5fc5dfc · 5fc5dfc
1 parent 66079cc
commit 5fc5dfc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/Dfe.PlanTech.Web/Controllers/PagesController.cs b/src/Dfe.PlanTech.Web/Controllers/PagesController.cs
@@ -1,5 +1,6 @@
 using System.Diagnostics;
 using Dfe.PlanTech.Application.Constants;
+using Dfe.PlanTech.Application.Exceptions;
 using Dfe.PlanTech.Domain.Content.Interfaces;
 using Dfe.PlanTech.Domain.Content.Models;
 using Dfe.PlanTech.Domain.Users.Interfaces;
@@ -11,6 +12,7 @@
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Options;
+using static Microsoft.ApplicationInsights.MetricDimensionNames.TelemetryContext;
 
 namespace Dfe.PlanTech.Web.Controllers;
 
@@ -33,7 +35,7 @@ public async Task<IActionResult> GetByRoute([ModelBinder(typeof(PageModelBinder)
         if (page == null)
         {
             logger.LogInformation("Could not find page at {Path}", Request.Path.Value);
-            return await NotFoundError();
+            throw new ContentfulDataUnavailableException($"Could not find page at {Request.Path.Value}");
         }
 
         var viewModel = new PageViewModel(page, this, user, Logger);

diff --git a/tests/Dfe.PlanTech.Web.UnitTests/Controllers/PagesControllerTests.cs b/tests/Dfe.PlanTech.Web.UnitTests/Controllers/PagesControllerTests.cs
@@ -1,4 +1,5 @@
 using System.Security.Claims;
+using Dfe.PlanTech.Application.Exceptions;
 using Dfe.PlanTech.Domain.Content.Interfaces;
 using Dfe.PlanTech.Domain.Content.Models;
 using Dfe.PlanTech.Domain.Cookie;
@@ -272,9 +273,9 @@ public async Task Should_ReturnNotFoundError_Page_When_Page_Is_Null()
 
             userSubstitute.GetOrganisationData().Returns(establishment);
 
-            var result = await _controller.GetByRoute(null, userSubstitute) as ViewResult;
+            var action = async () => await _controller.GetByRoute(null, userSubstitute);
 
-            Assert.NotNull(result);
+            await Assert.ThrowsAsync<ContentfulDataUnavailableException>(action);
         }
 
         [Fact]