feat: Add handling for missing interstitial page #1776
jimwashbrook
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
code-pr-check.yml
on: push
Get Directories for Linting
0s
Build database upgrader
31s
Run javascript tests
15s
Matrix: Lint & Commit
Build and run unit tests
1m 41s
Annotations
3 errors and 12 warnings
|
Build and run unit tests:
tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetPageQueryTests.cs#L285
'GetPageQuery' does not contain a constructor that takes 6 arguments
|
|
Build and run unit tests:
tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetPageQueryTests.cs#L285
'GetPageQuery' does not contain a constructor that takes 6 arguments
|
|
Build and run unit tests
Process completed with exit code 1.
|
|
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Domain/Content/Interfaces/IRichTextContent.cs#L38
Reduce the number of generic parameters in the 'IRichTextContent' interface to no more than the 2 authorized. (https://rules.sonarsource.com/csharp/RSPEC-2436)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Domain/Questionnaire/Interfaces/ISection.cs#L19
Reduce the number of generic parameters in the 'ISection' interface to no more than the 2 authorized. (https://rules.sonarsource.com/csharp/RSPEC-2436)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Domain/Content/Interfaces/IRichTextContent.cs#L23
"Find" method should be used instead of the "FirstOrDefault" extension method. (https://rules.sonarsource.com/csharp/RSPEC-6602)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Domain/Content/Models/Options/TextRendererOptions.cs#L18
"Find" method should be used instead of the "FirstOrDefault" extension method. (https://rules.sonarsource.com/csharp/RSPEC-6602)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Application/Submissions/Queries/SubmissionStatusProcessor.cs#L65
"Find" method should be used instead of the "FirstOrDefault" extension method. (https://rules.sonarsource.com/csharp/RSPEC-6602)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Application/Submissions/Queries/GetSubmissionStatusesQuery.cs#L65
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
|
|
Build and run unit tests:
src/Dfe.PlanTech.AzureFunctions/Mappings/PageMapper.cs#L21
'System.Exception' should not be thrown by user code. (https://rules.sonarsource.com/csharp/RSPEC-112)
|
|
Build and run unit tests:
src/Dfe.PlanTech.AzureFunctions/Mappings/JsonToEntityMappers.cs#L31
'System.Exception' should not be thrown by user code. (https://rules.sonarsource.com/csharp/RSPEC-112)
|
|
Build and run unit tests:
src/Dfe.PlanTech.AzureFunctions/Mappings/JsonToDbMapper.cs#L32
'System.NullReferenceException' should not be thrown by user code. (https://rules.sonarsource.com/csharp/RSPEC-112)
|