Story/241800 user redirect #3847
DrewAirecode-pr-check.yml
on: pull_request
Lint & Commit
1m 2s
Build database upgrader
25s
Run javascript tests
14s
Build and run unit tests
2m 34s
Annotations
1 error and 12 warnings
|
Build and run unit tests
Process completed with exit code 100.
|
|
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Infrastructure.SignIn/ConnectEvents/OnUserInformationReceivedEvent.cs#L55
The parameter name 'EstablishmentId' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Middleware/RobotsTxtMiddleware.cs#L10
Parameter '_' is unread.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Controllers/PagesController.cs#L33
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Helpers/MaintainUrlOnKeyNotFoundAttribute.cs#L14
Specify AttributeUsage on 'MaintainUrlOnKeyNotFoundAttribute' to improve readability, even though it inherits it from its base type. (https://rules.sonarsource.com/csharp/RSPEC-3993)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Middleware/ServiceExceptionHandlerMiddleWare.cs#L29
Remove the unused local variable 'exception'. (https://rules.sonarsource.com/csharp/RSPEC-1481)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Middleware/ServiceExceptionHandlerMiddleWare.cs#L38
Make 'ContextRedirect' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
|
|
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Infrastructure.SignIn/ConnectEvents/OnUserInformationReceivedEvent.cs#L55
The parameter name 'EstablishmentId' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928)
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Middleware/RobotsTxtMiddleware.cs#L10
Parameter '_' is unread.
|