Skip to content
Code PR Check

feat(241800): Prevent redirection on not-found, keeping URL the same #3840

Sign in to view logs

feat(241800): Prevent redirection on not-found, keeping URL the same

feat(241800): Prevent redirection on not-found, keeping URL the same #3840

Triggered via pull request February 27, 2025 16:55
@DrewAireDrewAire
synchronize #967
story/241800-user-redirect
Status Failure
Total duration 3m 48s
Artifacts –

code-pr-check.yml

on: pull_request
Lint & Commit
53s
Lint & Commit
Build database upgrader
27s
Build database upgrader
Run javascript tests
16s
Run javascript tests
Build and run unit tests
2m 27s
Build and run unit tests
Fit to window
Zoom out
Zoom in

Annotations

1 error and 12 warnings
Build and run unit tests
Process completed with exit code 100.
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build and run unit tests: src/Dfe.PlanTech.Application/Persistence/Interfaces/IContentRepository.cs#L37
All 'GetEntities' method overloads should be adjacent. (https://rules.sonarsource.com/csharp/RSPEC-4136)
Build and run unit tests: src/Dfe.PlanTech.Infrastructure.SignIn/ConnectEvents/OnUserInformationReceivedEvent.cs#L55
The parameter name 'EstablishmentId' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928)
Build and run unit tests: src/Dfe.PlanTech.Web/Controllers/PagesController.cs#L32
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build and run unit tests: src/Dfe.PlanTech.Web/Middleware/RobotsTxtMiddleware.cs#L10
Parameter '_' is unread.
Build and run unit tests: src/Dfe.PlanTech.Web/Helpers/MaintainUrlOnKeyNotFoundAttribute.cs#L14
Specify AttributeUsage on 'MaintainUrlOnKeyNotFoundAttribute' to improve readability, even though it inherits it from its base type. (https://rules.sonarsource.com/csharp/RSPEC-3993)
Build and run unit tests: src/Dfe.PlanTech.Web/Controllers/CmsController.cs#L34
Use PascalCase for named placeholders. (https://rules.sonarsource.com/csharp/RSPEC-6678)
Build and run unit tests: src/Dfe.PlanTech.Web/Middleware/ServiceExceptionHandlerMiddleWare.cs#L38
Make 'ContextRedirect' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
Build and run unit tests: src/Dfe.PlanTech.Web/Middleware/ServiceExceptionHandlerMiddleWare.cs#L29
Remove the unused local variable 'exception'. (https://rules.sonarsource.com/csharp/RSPEC-1481)
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.