Skip to content
Code PR Check

feat(241800): Prevent redirection on not-found, keeping URL the same #3818

Sign in to view logs

feat(241800): Prevent redirection on not-found, keeping URL the same

feat(241800): Prevent redirection on not-found, keeping URL the same #3818

Triggered via pull request February 20, 2025 10:40
@DrewAireDrewAire
synchronize #967
story/241800-user-redirect
Status Success
Total duration 4m 46s
Artifacts 1

code-pr-check.yml

on: pull_request
Lint & Commit
1m 10s
Lint & Commit
Build database upgrader
38s
Build database upgrader
Run javascript tests
17s
Run javascript tests
Build and run unit tests
3m 18s
Build and run unit tests
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build and run unit tests: src/Dfe.PlanTech.Infrastructure.SignIn/ConnectEvents/OnUserInformationReceivedEvent.cs#L55
The parameter name 'EstablishmentId' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928)
Build and run unit tests: src/Dfe.PlanTech.Web/Middleware/RobotsTxtMiddleware.cs#L10
Parameter '_' is unread.
Build and run unit tests: src/Dfe.PlanTech.Web/Helpers/MaintainUrlOnKeyNotFoundAttribute.cs#L13
Specify AttributeUsage on 'MaintainUrlOnKeyNotFoundAttribute' to improve readability, even though it inherits it from its base type. (https://rules.sonarsource.com/csharp/RSPEC-3993)
Build and run unit tests: src/Dfe.PlanTech.Web/Middleware/ServiceExceptionHandlerMiddleWare.cs#L29
Remove the unused local variable 'exception'. (https://rules.sonarsource.com/csharp/RSPEC-1481)
Build and run unit tests: src/Dfe.PlanTech.Web/Middleware/ServiceExceptionHandlerMiddleWare.cs#L38
Make 'ContextRedirect' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build and run unit tests: src/Dfe.PlanTech.Infrastructure.SignIn/ConnectEvents/OnUserInformationReceivedEvent.cs#L55
The parameter name 'EstablishmentId' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928)
Build and run unit tests: src/Dfe.PlanTech.Web/Middleware/RobotsTxtMiddleware.cs#L10
Parameter '_' is unread.
Build and run unit tests: src/Dfe.PlanTech.Web/Helpers/MaintainUrlOnKeyNotFoundAttribute.cs#L13
Specify AttributeUsage on 'MaintainUrlOnKeyNotFoundAttribute' to improve readability, even though it inherits it from its base type. (https://rules.sonarsource.com/csharp/RSPEC-3993)

Artifacts

Produced during runtime
Name Size
code-coverage-report
61.9 KB