-
Notifications
You must be signed in to change notification settings - Fork 9
[781] publish edit a courses visa sponsorship application deadline #5120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[781] publish edit a courses visa sponsorship application deadline #5120
Conversation
Deployments
|
7edd5e2
to
dc58c46
Compare
98e8c82
to
34f1272
Compare
34f1272
to
a23d9c7
Compare
a23d9c7
to
b85b247
Compare
4c450f6
to
a66077a
Compare
a66077a
to
81ae45c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, juggling the origin is tricky and doesn't immediately appear to be an elegant way of doing it.
I've made some comments and questions
app/controllers/publish/courses/visa_sponsorship_application_deadline_date_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/publish/courses/visa_sponsorship_application_deadline_date_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/publish/courses/visa_sponsorship_application_deadline_date_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/publish/courses/visa_sponsorship_application_deadline_required_controller.rb
Outdated
Show resolved
Hide resolved
app/views/publish/courses/visa_sponsorship_application_deadline_date/edit.html.erb
Show resolved
Hide resolved
app/views/publish/courses/visa_sponsorship_application_deadline_date/edit.html.erb
Outdated
Show resolved
Hide resolved
app/views/publish/courses/visa_sponsorship_application_deadline_required/edit.html.erb
Outdated
Show resolved
Hide resolved
57045b2
to
abf8e3e
Compare
abf8e3e
to
2d196f0
Compare
2d196f0
to
6347fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last review, done enought here I think.
Apart from comments, I think we can change the messages back to how they are formatted in the rest of the update actions
Subjects updated
Visa sponsorship updated
app/forms/publish/visa_sponsorship_application_deadline_date_form.rb
Outdated
Show resolved
Hide resolved
app/forms/publish/visa_sponsorship_application_deadline_date_form.rb
Outdated
Show resolved
Hide resolved
app/forms/publish/visa_sponsorship_application_deadline_date_form.rb
Outdated
Show resolved
Hide resolved
app/controllers/publish/courses/visa_sponsorship_application_deadline_date_controller.rb
Outdated
Show resolved
Hide resolved
b770b01
to
3daa401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for this 🚀
…ng visa sponsorship
3daa401
to
11dde4e
Compare
Context
We have already added the create flow for including an application deadline for those candidate requiring sponsorship. This PR adds the edit flow.
Changes proposed in this pull request
One of the complications in this flow is that there are 4 ways to get to the point of changing the date:
So the success messages need to be aware of where the user entered the journey. so an
origin
needs to be passed around.Video
Editing.visa.sponsorship.mov
Guidance to review
Unfortunately, can't deploy a review app. But editing funding type, visa sponsorship and deadlines in various scenarios would be very helpful. You'll need to activate the feature flag
visa_sponsorship_deadline
.Checklist
data-qa
attributes in HTML files and updated the corresponding tests.