Skip to content

[781] publish edit a courses visa sponsorship application deadline #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Apr 2, 2025

Context

We have already added the create flow for including an application deadline for those candidate requiring sponsorship. This PR adds the edit flow.

Changes proposed in this pull request

  • Edit / update actions to the controllers, along with associated views
  • Updates to the date validation after content review -- this impacts both edit / create flows.
  • Changes to the success messages after content review

One of the complications in this flow is that there are 4 ways to get to the point of changing the date:

  1. funding_type -> visa_sponsorship -> deadline_required -> deadline
  2. visa_sponsorship -> deadline_required -> deadline
  3. deadline_required -> deadline
  4. deadline

So the success messages need to be aware of where the user entered the journey. so an origin needs to be passed around.

Video

Editing.visa.sponsorship.mov

Guidance to review

Unfortunately, can't deploy a review app. But editing funding type, visa sponsorship and deadlines in various scenarios would be very helpful. You'll need to activate the feature flag visa_sponsorship_deadline .

Checklist

  • I have moved hard-coded strings to locale files.
  • I have removed the usage of data-qa attributes in HTML files and updated the corresponding tests.

@elceebee elceebee self-assigned this Apr 2, 2025
@elceebee elceebee added the deploy A Review App will be created for PRs with this label label Apr 2, 2025
Copy link

github-actions bot commented Apr 2, 2025

@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from 7edd5e2 to dc58c46 Compare April 3, 2025 15:00
@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch 2 times, most recently from 98e8c82 to 34f1272 Compare April 4, 2025 11:26
@elceebee elceebee marked this pull request as ready for review April 4, 2025 12:25
@elceebee elceebee requested a review from a team as a code owner April 4, 2025 12:25
@elceebee elceebee changed the title DRAFT 781 publish edit a courses visa sponsorship application deadline [781] publish edit a courses visa sponsorship application deadline Apr 4, 2025
@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from 34f1272 to a23d9c7 Compare April 7, 2025 13:00
@elceebee
Copy link
Contributor Author

elceebee commented Apr 7, 2025

@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from a23d9c7 to b85b247 Compare April 9, 2025 09:48
@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from 4c450f6 to a66077a Compare April 10, 2025 09:42
@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from a66077a to 81ae45c Compare April 10, 2025 15:36
Copy link
Contributor

@inulty-dfe inulty-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, juggling the origin is tricky and doesn't immediately appear to be an elegant way of doing it.

I've made some comments and questions

@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch 2 times, most recently from 57045b2 to abf8e3e Compare April 11, 2025 12:51
@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from abf8e3e to 2d196f0 Compare April 14, 2025 09:33
@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from 2d196f0 to 6347fd1 Compare April 14, 2025 14:06
Copy link
Contributor

@inulty-dfe inulty-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last review, done enought here I think.

Apart from comments, I think we can change the messages back to how they are formatted in the rest of the update actions

Subjects updated
Visa sponsorship updated

@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from b770b01 to 3daa401 Compare April 14, 2025 17:10
@elceebee elceebee requested a review from inulty-dfe April 14, 2025 17:15
Copy link
Contributor

@inulty-dfe inulty-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for this 🚀

@elceebee elceebee force-pushed the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch from 3daa401 to 11dde4e Compare April 15, 2025 08:40
@elceebee elceebee closed this Apr 15, 2025
@elceebee elceebee reopened this Apr 15, 2025
@elceebee elceebee merged commit 5e23a85 into main Apr 15, 2025
36 checks passed
@elceebee elceebee deleted the 781-publish-edit-a-courses-visa-sponsorship-application-deadline branch April 15, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants