Skip to content

Validate provider code is uppercase #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

inulty-dfe
Copy link
Contributor

@inulty-dfe inulty-dfe commented Apr 2, 2025

Context

We had a support issue some time back where someone created a provider and one or more of the letters were entered downcase. The providers courses would not load on find.

Changes proposed in this pull request

Validate that when creating a new Provider that their provider code is the correct format:

  • 3 characters long
  • At least one number
  • the other two characters can be numbers or letters.
  • Any order

Add normalization to the provider_code column so that any input is upcased.

Guidance to review

Provide code length Doesn't validate upcase Validates invalid format
image image image

Trello

https://trello.com/c/7NsqwHo4/527-bug-validate-upper-case-provider-code-on

Checklist

  • I have moved hard-coded strings to locale files.
  • I have removed the usage of data-qa attributes in HTML files and updated the corresponding tests.

@inulty-dfe inulty-dfe requested a review from a team as a code owner April 2, 2025 13:41
@inulty-dfe inulty-dfe added the deploy A Review App will be created for PRs with this label label Apr 2, 2025
@inulty-dfe inulty-dfe force-pushed the im/validate-provider-code-is-uppercase branch 2 times, most recently from 17c53bf to cca231c Compare April 2, 2025 14:33
@inulty-dfe inulty-dfe requested a review from joegibb April 2, 2025 14:36
Copy link

github-actions bot commented Apr 2, 2025

Copy link
Contributor

@Nitemaeric Nitemaeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we normalise the uppercase-ness instead of validating it?

@inulty-dfe
Copy link
Contributor Author

Could we normalise the uppercase-ness instead of validating it?

Yeah, this is probably a good idea. Are you recommending we spend time doing this?

@Nitemaeric
Copy link
Contributor

Yeah, this is probably a good idea. Are you recommending we spend time doing this?

Yes, please. 🙏

@inulty-dfe inulty-dfe force-pushed the im/validate-provider-code-is-uppercase branch from cca231c to 9ad1644 Compare April 7, 2025 08:22
@inulty-dfe inulty-dfe requested a review from Nitemaeric April 7, 2025 08:30
@inulty-dfe inulty-dfe force-pushed the im/validate-provider-code-is-uppercase branch from 9ad1644 to f71d8d9 Compare April 7, 2025 09:51
@inulty-dfe inulty-dfe force-pushed the im/validate-provider-code-is-uppercase branch from f71d8d9 to 13fd1f0 Compare April 7, 2025 16:20
@inulty-dfe inulty-dfe merged commit 00217df into main Apr 8, 2025
34 checks passed
@inulty-dfe inulty-dfe deleted the im/validate-provider-code-is-uppercase branch April 8, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants