-
Notifications
You must be signed in to change notification settings - Fork 9
Validate provider code is uppercase #5119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17c53bf
to
cca231c
Compare
Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we normalise the uppercase-ness instead of validating it?
Yeah, this is probably a good idea. Are you recommending we spend time doing this? |
Yes, please. 🙏 |
cca231c
to
9ad1644
Compare
9ad1644
to
f71d8d9
Compare
f71d8d9
to
13fd1f0
Compare
Context
We had a support issue some time back where someone created a provider and one or more of the letters were entered downcase. The providers courses would not load on find.
Changes proposed in this pull request
Validate that when creating a new Provider that their provider code is the correct format:
Add normalization to the provider_code column so that any input is upcased.
Guidance to review
Trello
https://trello.com/c/7NsqwHo4/527-bug-validate-upper-case-provider-code-on
Checklist
data-qa
attributes in HTML files and updated the corresponding tests.