Add multiple schools publish interface #5115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inulty-dfe
force-pushed
the
im/add-multiple-schools-publish-interface
branch
from
78264ca to
fd4d559
Compare
Deployments
|
- When Adding a new school, the search page will redirect directly to the Checks page.
- The SchoolForm is not required in the Checks controller, just use
the Site object
- Update the autocomplete search input id - add providers namespace
- Update StudySite tests and translations to work with updated
autocomplete
URNForm will be used in Support and Publish interfaces.
inulty-dfe
force-pushed
the
im/add-multiple-schools-publish-interface
branch
from
fd4d559 to
29d43dd
Compare
inulty-dfe
force-pushed
the
im/add-multiple-schools-publish-interface
branch
from
f46d9ae to
97867cd
Compare
spec/features/publish/providers/schools/creating_multiple_schools_spec.rb
Outdated
Show resolved
Hide resolved
Nitemaeric
reviewed
Apr 3, 2025
inulty-dfe
force-pushed
the
im/add-multiple-schools-publish-interface
branch
from
97867cd to
6700692
Compare
inulty-dfe
force-pushed
the
im/add-multiple-schools-publish-interface
branch
from
6700692 to
60b0c16
Compare
tomas-stefano
approved these changes
Apr 7, 2025
Nitemaeric
reviewed
Apr 7, 2025
app/controllers/publish/providers/schools/check_multiple_controller.rb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are adding the ability for providers to add multiple schools to their provider account.
They will be able to input a set of URNs delimited by comma (,) or newline (\n).
This feature was recently added to Support.
Changes proposed in this pull request
Providers can now add multiple schools to their provider account.
Guidance to review
Kazam_screencast_00000.mp4
Trello
https://trello.com/c/S0fBUr6R/538-add-add-multiple-schools-flow-for-provider-interface
Checklist
data-qaattributes in HTML files and updated the corresponding tests.