Remove provider partnerships feature switches #5100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inulty-dfe
force-pushed
the
im/remove-provider-partnerships-feature-switches
branch
from
e159254 to
98823ac
Compare
inulty-dfe
changed the title
Deployments
|
This commit only removes the places where the code switches based on `Settings.features.provider_partnerships` This includes the tests, but not routes
inulty-dfe
force-pushed
the
im/remove-provider-partnerships-feature-switches
branch
from
98823ac to
3434418
Compare
inulty-dfe
force-pushed
the
im/remove-provider-partnerships-feature-switches
branch
from
3434418 to
d9454d2
Compare
tomas-stefano
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We added a feature flag and many feature switches to the code so we could release ProviderPartnerships alongside the existing Enrichments implementation.
These switches need to be removed now, leaving only the Provider Partnership branches.
Some of these switches are in methods, some load different components or templates.
The remaining instances are in the routing constraint and in
Provider#accredited_bodies.The routing one will be removed when all the old controllers and view are removed.
The
accredited_bodiesone will be removed as above, the methods in Provider need to be refactored and I didn't want to do that in this PR.Changes proposed in this pull request
Guidance to review
Trello
https://trello.com/c/HrBO8F7p
Checklist
data-qaattributes in HTML files and updated the corresponding tests.