[Docs] Add conventions documentation #4718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitemaeric
changed the title
Nitemaeric
force-pushed
the
dd/application-architecture-and-conventions
branch
from
dd2d946 to
9717ef7
Compare
Nitemaeric
force-pushed
the
dd/application-architecture-and-conventions
branch
5 times, most recently
from
472f038 to
56b2d28
Compare
Nitemaeric
force-pushed
the
dd/application-architecture-and-conventions
branch
2 times, most recently
from
6acb1b7 to
36c209e
Compare
Nitemaeric
force-pushed
the
dd/application-architecture-and-conventions
branch
from
36c209e to
24707cd
Compare
Nitemaeric
force-pushed
the
dd/application-architecture-and-conventions
branch
from
24707cd to
fc8c0be
Compare
Nitemaeric
changed the title
|
|
||
| def t(key, options = {}) | ||
| I18n.t(key, options.merge(scope: [:forms, *options[:scope]])) | ||
| end |
There was a problem hiding this comment.
If we need to call in the view, is the idea to:
form.object.t('.something')
There was a problem hiding this comment.
No. This is for internally within the object itself. t should be private.
tomas-stefano
approved these changes
Apr 2, 2025
If there is no service namespace, it would be considered shared code :) |
Nitemaeric
force-pushed
the
dd/application-architecture-and-conventions
branch
from
fc8c0be to
b658034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to align on how the Publish Teacher Training code should be written.
Update: In order to turn this into a collaboratively iterative process, let's start here and add more content in separate PRs.
Changes proposed in this pull request
Guidance to review
View the documentation here: