Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER-1187 Aria landmark update #1215

Merged
merged 7 commits into from
Jun 11, 2024
Merged

ER-1187 Aria landmark update #1215

merged 7 commits into from
Jun 11, 2024

Conversation

martikat
Copy link
Contributor

@martikat martikat commented Jun 6, 2024

@martikat martikat added this to the rc0.14.8 (mailer and header) milestone Jun 6, 2024
@martikat martikat added the review Review app deployed to Azure label Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

@instantrick
Copy link

@martikat The CDT version all looks good and is passing the accessibility checking tool now for the landmarks.

Copy link
Contributor

@peterdavidhamilton peterdavidhamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks logical, I'll let @instantrick reapprove

@instantrick
Copy link

@martikat The my account page and the forms that are part of the user settings do not have the

component in them and the formatting looks a bit strange at the top of the page

image image

Copy link

@instantrick instantrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now

@martikat martikat merged commit dabf67c into main Jun 11, 2024
4 checks passed
@peterdavidhamilton peterdavidhamilton deleted the ER-1187-aria-landmark-update branch July 26, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Changes to assets detected review Review app deployed to Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants