Skip to content

Commit

Permalink
add returnReference as second orderby column (#1611)
Browse files Browse the repository at this point in the history
https://eaflood.atlassian.net/browse/WATER-4863

As part of the testing on the historic changes for a return version it was noticed that some of the return logs from the first page are showing up on the second page as well.

This fix adds a second orderBy column to resolve the issue.
  • Loading branch information
robertparkinson authored Jan 14, 2025
1 parent bc433c5 commit a4956e3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/services/licences/fetch-licence-returns.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ async function _fetch(licenceId, page) {
])
.innerJoinRelated('licence')
.where('licence.id', licenceId)
.orderBy([{ column: 'dueDate', order: 'desc' }])
.orderBy([{ column: 'dueDate', order: 'desc' }, { column: 'returnReference' }])
.page(page - 1, DatabaseConfig.defaultPageSize)
}

Expand Down

0 comments on commit a4956e3

Please sign in to comment.